allow the TextAreaFormField to be used with valid/invalid HTML #10140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @dawehner. |
fabpot
added a commit
that referenced
this pull request
Jan 26, 2014
…HTML (dawehner) This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #10140). Discussion ---------- allow the TextAreaFormField to be used with valid/invalid HTML The TextAreaFormField previously used saveXML to get a representation of the child nodes of an textarea. This works pretty fine on simple text is causes issues in case you have broken HTML, as saveXML will potentially also break encoding/change the structure. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT Commits ------- 157a9de allow the TextAreaFormField to be used with valid/invalid HTML
|
wholeText only works for DOMText and fails on DOMNode, which leads to |
|
@Defimas Please open a new issue with some instructions on how to reproduce if you think you discovered a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TextAreaFormField previously used saveXML to get a representation of the child nodes of an textarea.
This works pretty fine on simple text is causes issues in case you have broken HTML, as saveXML
will potentially also break encoding/change the structure.