8000 Remove obsolete conditions by fabpot · Pull Request #10132 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Remove obsolete conditions #10132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2014
Merged

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jan 25, 2014
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

In composer.json, Twig version is set to 1.12 as a minimum, so all conditions about earlier Twig versions can be safely removed.

@stloyd
Copy link
Contributor
stloyd commented Jan 25, 2014

👍

1 similar comment
@sstok
Copy link
Contributor
sstok commented Jan 25, 2014

👍

fabpot added a commit that referenced this pull request Jan 25, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Remove obsolete conditions

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

In `composer.json`, Twig version is set to 1.12 as a minimum, so all conditions about earlier Twig versions can be safely removed.

Commits
-------

c3ff76a [Twig] removed obsolete conditions on Twig versions
@fabpot fabpot merged commit c3ff76a into symfony:2.3 Jan 25, 2014
@fabpot fabpot deleted the remove-obsolete-conditions branch February 3, 2014 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0