-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Weird error on GAE environment php sdk with Symfony #9483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm having the same error. Funny part is that it is not always there, but once it is there, it won't go away until I restart the server. Issue is only in dev mode. I'm not running on a GAE environment though. Only Apache 2.4, PHP 5.6 (with xdebug), MySQL 5.6, Symfony 2.3.6 / 2.3.7 / 2.4-beta2. |
this is a separate error and it has to do with the php and libs the GAE devkit uses, it is just messed up |
I've submitted a PR in #10493 that should solve this issue, can you have a look? |
…tity_loader usage (romainneutron) This PR was merged into the 2.3 branch. Discussion ---------- [2.3] Fix libxml_use_internal_errors and libxml_disable_entity_loader usage | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9731, #9483 | License | MIT This should fix #9731 and #9483 that seems to be triggered when `libxml_disable_entity_loader` has been called with `true` (see https://bugs.php.net/bug.php?id=62577) As `libxml_disable_entity_loader` is non thread safe (see https://bugs.php.net/bug.php?id=64938) and as we have some calls that might leave the setting to `true`, I think the bug should be fixed. I've checked the use of both `libxml_use_internal_errors` and `libxml_disable_entity_loader` among symfony code. You can see I prefered to skip DomDocument::loadXML warnings using the `@` instead of using `LIBXML_NOERROR | LIBXML_NO_WARNING` because we can log these errors whereas libxml errors would be furtives. - [x] Check calls to DOMDocument::load - [x] Check calls to DOMDocument::loadXML - [x] Check calls to DOMDocument::loadHTML - [x] Check calls to DOMDocument::loadHTMLFile - [x] Add more tests Commits ------- 489b8ae Fix libxml_use_internal_errors and libxml_disable_entity_loader usage
Check PR #11259 if you're still having issues with this. |
The text was updated successfully, but these errors were encountered: