8000 Implement SSI sub-request strategy · Issue #9419 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Implement SSI sub-request strategy #9419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hason opened this issue Oct 31, 2013 · 7 comments
Closed

Implement SSI sub-request strategy #9419

hason opened this issue Oct 31, 2013 · 7 comments
Labels
Feature Good first issue Ideal for your first contribution! (some Symfony experience may be required) HttpKernel

Comments

@hason
Copy link
Contributor
hason commented Oct 31, 2013

SSI support was planned for Symfony 2.3 as mentioned in the blog post http://symfony.com/blog/new-in-symfony-2-2-the-new-fragment-sub-framework.

Closed PRs: #6108, #6720, #6766
@mfoti
Copy link
Contributor
mfoti commented Nov 15, 2013

+1

@hason
Copy link
Contributor Author
hason commented Jan 27, 2014

https://github.com/KingCrunch/SSIBundle

@fabpot
Copy link
Member
fabpot commented Mar 3, 2014

Anyone willing to work on this one? It should be relatively easy by basing the work on the current ESI implementation.

@pborreli
Copy link
Contributor
pborreli commented Mar 3, 2014

it would be great 🚤 /ping @kingcrunch

@kingcrunch
Copy link
Contributor

I slightly remember, why I abanonded the PRs and build it up as separate bundle. The changes would introduce several BC-breaks (renaming interfaces at least, some different signatures, especially constructor (HttpCache) and so one), because right now it is somehow hardwired to Esi).

I also wont promise to find time. It's a quite busy time for me right now. But I'd surely like to give it a second try (although I wouldn't be too sad, if somebody else would take it over 😉 )

@estahn
Copy link
estahn commented Mar 8, 2014

👍

@javiereguiluz javiereguiluz mentioned this issue Apr 10, 2014
Closed
@kingcrunch kingcrunch mentioned this issue Apr 13, 2014
Merged
@netmikey
Copy link

👍

fabpot added a commit that referenced this issue Jul 25, 2014
@fabpot
feature #10702 [HttpKernel][FrameworkBundle] SSI support (KingCrunch)
bf140a8 
This PR was merged into the 2.6-dev branch.

Discussion
----------

[HttpKernel][FrameworkBundle] SSI support

| Q             | A
| ------------- | ---
| Bug fix?      | No
| New feature?  | Yes
| BC breaks?    | No
| Deprecations? | No
| Tests pass?   | Yes
| Fixed tickets | #9419 (, #10684)
| License       | MIT

It does not support comments, or alternative URIs, or "continue" in case of errors. Maybe I can workaround that, but I've decided to left it out for this PR. Especially as far as I can see a "alternative URIs"-hack would _always_ lead to two requests, even if it's not needed.

Commits
-------

06cea08 SSI support
@fabpot fabpot closed this as completed Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Good first issue Ideal for your first contribution! (some Symfony experience may be required) HttpKernel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@fabpot @pborreli @kingcrunch @hason @mfoti @estahn @netmikey
0