8000 [Translation] Why does FileDumper automatically backups a file? · Issue #9172 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] Why does FileDumper automatically backups a file? #9172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ruudk opened this issue Sep 30, 2013 · 9 comments
Closed

[Translation] Why does FileDumper automatically backups a file? #9172

ruudk opened this issue Sep 30, 2013 · 9 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Translation

Comments

@ruudk
Copy link
Contributor
ruudk commented Sep 30, 2013

The FileDumper automatically creates a backup of a file (filename.yml~).

Why is this the default behavior? It should be an option in my opinion.
@jakzal
Copy link
Contributor
jakzal commented Dec 28, 2013

This is how @michelsalib originally implemented it in #2051 over two years ago. No one ever complained.

Source code should be version controlled and I'm not sure why the backup is made. Feel free to submit a PR which would enable users to disable this behaviour.

@wouterj
Copy link
Member
wouterj commented Dec 28, 2013

The problem is that it'll be a bc break...

@jakzal
Copy link
Contributor
jakzal commented Dec 28, 2013

@wouterj since this would be an option we can keep bc if the default is to do the backup.

@fabpot
Copy link
Member
fabpot commented Apr 28, 2014

Anyone willing to implement this? Or can we close this issue?

@umpirsky
Copy link
Contributor

@fabpot I can submit PR. Feel free to assign me this issue.

@stof
Copy link
Member
stof commented Apr 29, 2014

@umpirsky we are not using the github assignees, because they are useless for us: only collaborators on the repo can be assigned on an issue

@umpirsky
Copy link
Contributor

@stof How do you prevent multiple people working on the same issue at the same time?

@stof
Copy link
Member
stof commented Apr 29, 2014

@umpirsky People telling they are working on it. And sometimes, duplicates happen.

@umpirsky
Copy link
Contributor

@fabpot I will implement it.

@umpirsky umpirsky mentioned this issue Apr 30, 2014
Closed
@fabpot fabpot closed this as completed May 4, 2014
fabpot added a commit that referenced this issue May 4, 2014
@fabpot
feature #10829 Fix issue 9172 (umpirsky)
9c1cdbd 
This PR was squashed before being merged into the 2.3-dev branch (closes #10829).

Discussion
----------

Fix issue 9172

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9172
| License       | MIT

Commits
-------

25f1d85 Fix issue 9172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @ruudk @jakzal @umpirsky @stof @wouterj
0