8000 HttpCache/Store removes "md" but leaves "en" files · Issue #6830 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

HttpCache/Store removes "md" but leaves "en" files #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
inrobin opened this issue Jan 22, 2013 · 1 comment
Closed

HttpCache/Store removes "md" but leaves "en" files #6830

inrobin opened this issue Jan 22, 2013 · 1 comment
Labels
Enhancement HttpKernel

Comments

@inrobin
Copy link
inrobin commented Jan 22, 2013

Currently /Symfony/Component/HttpKernel/HttpCache/Store removes only metadata files in /app/cache/dev/http_cache/md (returned by $this->getCacheKey) and leaves /app/cache/dev/http_cache/en:

<?php
  /**
      * Purges data for the given URL.
      *
      * @param string $url A URL
      *
      * @return Boolean true if the URL exists and has been purged, false otherwise
      */
     public function purge($url)
     {
         if (is_file($path = $this->getPath($this->getCacheKey(Request::create($url))))) {
             unlink($path);

             return true;
         }

         return false;
     }

What about removing files from /app/cache/dev/http_cache/en on purge too?
@bamarni bamarni mentioned this issue Mar 13, 2013
Closed
@bamarni
Copy link
Contributor
bamarni commented Mar 13, 2013

this can be closed

@bamarni bamarni mentioned this issue Mar 17, 2013
Merged
fabpot added a commit that referenced this issue Mar 18, 2013
@fabpot
merged branch bamarni/issue-6830 (PR #7408)
46341e1 
This PR was merged into the 2.1 branch.

Commits
-------

54609b9 [HttpCache] added a test (cached content should be kept after purging)

Discussion
----------

[HttpCache] added a test (cached content should be kept after purging)

closes #6830
@fabpot fabpot closed this as completed Mar 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement HttpKernel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @bamarni @inrobin
0