8000 ApplicationTester should setAutoExit to false · Issue #6464 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

ApplicationTester should setAutoExit to false #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glenjamin opened this issue Dec 22, 2012 · 4 comments
Closed

ApplicationTester should setAutoExit to false #6464

glenjamin opened this issue Dec 22, 2012 · 4 comments
Labels
Console

Comments

@glenjamin
Copy link

This one caught me out just now, if there's a strong reason why this shouldn't disable the exit behaviour, then could a note be added to the tip in this section http://symfony.com/doc/current/components/console/introduction.html#testing-commands which references ApplicationTester?
@fabpot fabpot mentioned this issue Jan 24, 2013
Merged
@fabpot
Copy link
Member
fabpot commented Jan 24, 2013

I have updated the phpdoc to warn about this.

@glenjamin
Copy link
Author

Seems sensible, but is there any particular reason not to have the ApplicationTester do this itself?

@fabpot
Copy link
Member
fabpot commented Jan 24, 2013

Yes, the Application is the object we want to test, the tester should not change it in any way.

@glenjamin
Copy link
Author

Makes sense, cheers. It'd be nice to have something that verifies this has been done at runtime, as well as the hint in the docs.

Perhaps the tester could inspect the object and raise an error if it's not set to AutoExit false?

@fabpot fabpot closed this as completed in e3086cc Jan 25, 2013
fabpot added a commit that referenced this issue Jan 25, 2013
@fabpot
merged branch fabpot/phpdoc-fix (PR #6869)
5381fae 
This PR was merged into the master branch.

Commits
-------

e3086cc [Console] added some missing information in the phpdoc (closes #6464)

Discussion
----------

[Console] added some missing information in the phpdoc (closes #6464)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6464
| License       | MIT
| Doc PR        | n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @glenjamin
0