8000 [HttpKernel] KernelTest::testGetRootDir fails on Windows for branch 2.0 · Issue #5341 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] KernelTest::testGetRootDir fails on Windows for branch 2.0 #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bdmu opened this issue Aug 25, 2012 · 0 comments
Closed

[HttpKernel] KernelTest::testGetRootDir fails on Windows for branch 2.0 #5341

bdmu opened this issue Aug 25, 2012 · 0 comments

Comments

@bdmu
Copy link
Contributor
bdmu commented Aug 25, 2012

Hello,

Running the command on branch 2.0:
phpunit tests/Symfony/Tests/Component/HttpKernel/

I get this error on Windows

  1. Symfony\Tests\Component\HttpKernel\KernelTest::testGetRootDir
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'C:\bdmu_git_repos\symfony\tests\Symfony\Tests\Component\HttpKernel'
    +'C:/bdmu_git_repos/symfony/tests/Symfony/Tests/Component/HttpKernel'

C:\bdmu_git_repos\symfony\tests\Symfony\Tests\Component\HttpKernel\KernelTest.php:287
C:\wamp\bin\php\pear\phpunit:46

replacing
$this->assertEquals(DIR, $kernel->getRootDir());
with
$this->assertEquals(DIR, realpath($kernel->getRootDir()));
line 287 fix the issue.

Best regards,
Christophe
@bdmu bdmu mentioned this issue Aug 25, 2012
Merged
fabpot added a commit that referenced this issue Aug 26, 2012
@fabpot
merged branch bdmu/ticket_5341 (PR #5342)
71f3081 
Commits
-------

9beffff [HttpKernel] KernelTest::testGetRootDir fails on Windows for branch 2.0

Discussion
----------

[HttpKernel] fix KernelTest::testGetRootDir fails on Windows for branch 2.0

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5341
Todo: -
License of the code: MIT
Documentation PR:
replace
$this->assertEquals(DIR, $kernel->getRootDir());
with
$this->assertEquals(DIR, realpath($kernel->getRootDir()));
line 287

---------------------------------------------------------------------------

by pborreli at 2012-08-25T20:23:34Z

:+1:
@fabpot fabpot closed this as completed Aug 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @bdmu
0