[Routing] Allow using invokable controller's FQCN (i.e. `::class`) to generate URLs (instead of route name) #49981

ThomasLandauer · 2023-04-08T16:30:12Z

Description

With the advent of invokable controllers, it would be possible to move away from using names (i.e. strings) as route idenfifiers, and use the controller's FQCN instead:

#[Route(path: '/some')]
final class SomeController
{
    public function __invoke(): Response
    {
        // ...
    }
}

Then in any service:

$this->router->generate(SomeController::class);

Twig:

{{ path('App\\Controller\\SomeController') }}

Advantage: No more strings! :-)

I got the idea from https://tomasvotruba.com/blog/to-route-or-to-action-thats-the-question which says that this is possible in Laravel:

It allows using the controller directly instead of a middleman string:
+<form action="{{ action(\App\Controllers\ProcessPhpFormController::class) }}" method="post">

Example

No response

The text was updated successfully, but these errors were encountered:

derrabus · 2023-04-08T17:47:48Z

I like the idea. However, we currently generate a name for routes already, if the name property is omitted. Silently changing the strategy how that name is generated would be a BC break.

ro0NL · 2023-04-08T18:17:44Z

https://symfony.com/blog/new-in-symfony-5-4-route-aliasing#deprecating-routes 👀

nicolas-grekas · 2023-04-19T16:23:38Z

Not sure I would deprecate the currently generated name, but why not create an alias indeed.
This would work only for invokable controllers.

…cable (fancyweb) This PR was merged into the 6.4 branch. Discussion ---------- [Routing] Add FQCN and FQCN::method aliases when applicable | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #49981 | License | MIT | Doc PR | - See #49981, I think it's a great idea 😃 * We add an FQCN alias only if the target class has an `__invoke` method that adds a route AND if the target class added 1 route exactly. * We add a FQCN::method alias for every method that defines only one route. Commits ------- 9fa5bae [Routing] Add FQCN and FQCN::method aliases when applicable

…cable (fancyweb) This PR was merged into the 6.4 branch. Discussion ---------- [Routing] Add FQCN and FQCN::method aliases when applicable | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | symfony/symfony#49981 | License | MIT | Doc PR | - See symfony/symfony#49981, I think it's a great idea 😃 * We add an FQCN alias only if the target class has an `__invoke` method that adds a route AND if the target class added 1 route exactly. * We add a FQCN::method alias for every method that defines only one route. Commits ------- 9fa5bae407 [Routing] Add FQCN and FQCN::method aliases when applicable

carsonbot added the Routing label Apr 8, 2023

This was referenced Apr 8, 2023

[Routing] Support PHP 8.1 enums as route name #44563

Closed

Moving #[Route()] attribute upwards symplify/phpstan-rules#31

Closed

derrabus added the Feature label Apr 8, 2023

nicolas-grekas added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Apr 19, 2023

fancyweb mentioned this issue Apr 20, 2023

[Routing] Add FQCN and FQCN::method aliases when applicable #50084

Merged

fabpot closed this as completed Jun 20, 2023

ThomasLandauer mentioned this issue Dec 8, 2023

[Routing] Use the controller's FQCN as default internal route name, instead of app_controller_method #52945

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Routing] Allow using invokable controller's FQCN (i.e. `::class`) to generate URLs (instead of route name) #49981

[Routing] Allow using invokable controller's FQCN (i.e. `::class`) to generate URLs (instead of route name) #49981

[Routing] Allow using invokable controller's FQCN (i.e. ::class) to generate URLs (instead of route name) #49981

[Routing] Allow using invokable controller's FQCN (i.e. ::class) to generate URLs (instead of route name) #49981

Comments

Description

Example

[Routing] Allow using invokable controller's FQCN (i.e. `::class`) to generate URLs (instead of route name) #49981

[Routing] Allow using invokable controller's FQCN (i.e. `::class`) to generate URLs (instead of route name) #49981