8000 [Console] Backslash cancels formatting · Issue #4885 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Backslash cancels formatting #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aldesantis opened this issue Jul 12, 2012 · 6 comments
Closed

[Console] Backslash cancels formatting #4885

aldesantis opened this issue Jul 12, 2012 · 6 comments
Labels
Console

Comments

@aldesantis
Copy link
Contributor

I just noticed something strange in the Console component:

// $output here being Symfony\Component\Console\Output\OutputInterface
$output->writeln('<comment>Symony\Component\Console does not work very well!</comment>');

You will notice that only "Symfony" is formatted correctly. Is this a known issue?

This is obviously producing some problems with the Symfony2 console (e.g. in the generate:bundle command):

Use / instead of </comment> for the namespace delimiter to avoid any problem.
@fabpot
Copy link
Member
fabpot commented Jul 13, 2012

ping @jfsimon

@jfsimon
Copy link
Contributor
jfsimon commented Jul 13, 2012

@fabpot I'm on it... not so easy.

@jfsimon jfsimon mentioned this issue Jul 13, 2012
Merged
@jfsimon
Copy link
Contributor
jfsimon commented Jul 13, 2012

@fabpot done

fabpot added a commit that referenced this issue Jul 13, 2012
@fabpot
merged branch jfsimon/issue-4885 (PR #4891)
7dc8901 
Commits
-------

3fef3c2 [Console] Fixed output formatter regex.
fea9d09 [Console] Added LG char escaping test.

Discussion
----------

Issue 4885

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4885
@fabpot fabpot closed this as completed Jul 13, 2012
@aldesantis
Copy link
Contributor Author

Well, this still happens with the < character, for instance in the doctrine:generate:entity command:

New field name (press <return> to stop adding fields):

The text turns white just after the word "press".

@jfsimon
Copy link
Contributor
jfsimon commented Aug 6, 2012

I opened an issue here: #5196
I fixed the problem here: #5194

@aldesantis
Copy link
Contributor Author

Thank you so much. This was a little detail, but very disturbing to the perfectionists like me. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @jfsimon @aldesantis
0