8000 [6.2] [Profiler] Toggler bug and search empty · Issue #48437 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[6.2] [Profiler] Toggler bug and search empty #48437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
youlead-bow opened this issue Dec 2, 2022 · 1 comment
Closed

[6.2] [Profiler] Toggler bug and search empty #48437

youlead-bow opened this issue Dec 2, 2022 · 1 comment
Labels
Bug Status: Needs Review WebProfilerBundle

Comments

@youlead-bow
Copy link

Symfony version(s) affected

6.2

Description

Using the new profiler, I encountered 2 issues:

  1. In the Forms tab of the profiler, the form tree no longer works. Nothing happens if you click on the plus pictograms.
    It does not display what it should and the picto does not change.

  2. When you want to display the last 10 urls, the list is always empty. The profiler search doesn't work.

For information, I emptied all the Symfony and browser cache, reinstalled the package but nothing changed.

How to reproduce

Open the profiler and go to the forms page or the last 10.

Possible Solution

  1. Add line in form.html.twig: toggler.initButtons(document.querySelectorAll('a.toggle-button'));
    For the picto I don't know what's wrong

  2. I don't know

Additional Context

toggler
empty_search
@youlead-bow youlead-bow added the Bug label Dec 2, 2022
@youlead-bow youlead-bow changed the title [Profiler] Toggle bug and history empty [6.2] [Profiler] Toggle bug and history empty Dec 2, 2022
@youlead-bow youlead-bow changed the title [6.2] [Profiler] Toggle bug and history empty [6.2] [Profiler] Toggler bug and history empty Dec 2, 2022
@youlead-bow youlead-bow changed the title [6.2] [Profiler] Toggler bug and history empty [6.2] [Profiler] Toggler bug and search empty Dec 2, 2022
@MatTheCat
Copy link
Contributor

Good catch 👍 Toggler.initButtons is never called in Collector/form.html.twig

Not able 8E96 to reproduce the issue about the empty URL list though. Do you have a profiler/index.csv file in your cache folder?

@MatTheCat MatTheCat mentioned this issue Dec 3, 2022
Merged
@fabpot fabpot closed this as completed Dec 4, 2022
fabpot added a commit that referenced this issue Dec 4, 2022
@fabpot
bug #48450 [WebProfilerBundle] Fix form panel expanders (MatTheCat)
8eab68d 
This PR was merged into the 6.2 branch.

Discussion
----------

[WebProfilerBundle] Fix form panel expanders

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #48437
| License       | MIT
| Doc PR        | N/A

`Toggler.initButtons` was not called so expanders did not work.

Commits
-------

43151a8 [WebProfilerBundle] Fix form panel expanders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @MatTheCat @carsonbot @youlead-bow
0