Password not working with an unix socket for Messenger redis transport #47393
Labels
Comments
|
If you want to, please give it a try. 👍 |
|
I tested it with different scenarios (socket, host, user / password or not) and it works just fine. Thanks for taking care of that ! |
This comment was marked as spam.
This comment was marked as spam.
nicolas-grekas
added a commit
that referenced
this issue
Jan 13, 2023
…kets (PhilETaylor) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Messenger] Allow password in redis dsn when using sockets | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #47393 `@Arakmar` | License | MIT | Doc PR | When a messenger async transport is configured with Redis (unix socket with a password), it gives DSN parsing errors. Using a Bunch of copy and pasted code blocks from the Redis cache adapter, this PR fixes the bug that doesn't parse a DSN such as `redis://password@/var/run/redis.sock` Replaces bad rebased #47475 Commits ------- 9af8ccf [Messenger] Allow password in redis dsn when using sockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected
6.1.3, 5.4.11
Description
When a messenger async transport is configured with Redis (unix socket with a password), it gives DSN parsing errors.
After looking at the code, the password is properly parsed only when a host is used.
It's also the same for the password option, it's not used in case of a socket.
The redis cache adapter doesn't seem to be affected by this problem. It allows DSN like that :
redis[s]://[pass@][ip|host|socket[:port]][/db-index]How to reproduce
Use a DSN like that for an async messenger queue :
redis://password@/var/run/redis.sockIt gives the following error :
Possible Solution
Add support for passwords with redis socket in the same way the redis cache adapter does.
I can propose a PR for that.
Additional Context
No response
The text was updated successfully, but these errors were encountered: