8000 [Notifier] [expo-notifier] Wrong service tag applied via framework bundle to ExpoTransportFactory · Issue #44833 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] [expo-notifier] Wrong service tag applied via framework bundle to ExpoTransportFactory #44833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahoendgen opened this issue Dec 28, 2021 · 1 comment · Fixed by #44920
Closed

[Notifier] [expo-notifier] Wrong service tag applied via framework bundle to ExpoTransportFactory #44833

ahoendgen opened this issue Dec 28, 2021 · 1 comment · Fixed by #44920
Labels
Bug Notifier Status: Needs Review

Comments

@ahoendgen
Copy link

Symfony version(s) affected

6.0.0

Description

The expo-notifier transport factory is tagged with chatter.transport_factory but must be tagged with texter.transport_factory to work properly.

symfony/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php

Line 243 in 60ce5a3

->tag('chatter.transport_factory')

How to reproduce

  • install only expo-notifier bundle
  • configure it via .env
  • try to send a message via autowired TexterInterface
  • see exception because NullTransportFactory won't pickup the expo schema

Possible Solution

change chatter.transport_factory to texter.transport_factory in

symfony/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php

Line 243 in 60ce5a3

->tag('chatter.transport_factory')

Additional Context

No response
@ahoendgen ahoendgen added the Bug label Dec 28, 2021
@OskarStark
Copy link
Contributor

It looks like you are right

image

Open for a bugfix PR?

Thanks

@jschaedl jschaedl mentioned this issue Jan 5, 2022
Merged
@fabpot fabpot closed this as completed Jan 9, 2022
fabpot pushed a commit that referenced this issue Jan 9, 2022
@jschaedl
Use correct tag for ExpoTransportFactory service
1d06c4e 
fixes #44833
fabpot added a commit that referenced this issue Jan 9, 2022
@fabpot
bug #44920 Use correct tag for ExpoTransportFactory service (jschaedl)
b626db7 
This PR was merged into the 5.4 branch.

Discussion
----------

Use correct tag for ExpoTransportFactory service

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #44833 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | -
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against the latest branch.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

1d06c4e Use correct tag for ExpoTransportFactory service
angelov pushed a commit to angelov/symfony that referenced this issue Jan 11, 2022
@jschaedl @angelov
Use correct tag for ExpoTransportFactory service
24e880f 
fixes symfony#44833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Notifier Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct tag for ExpoTransportFactory service jschaedl/symfony
4 participants
@fabpot @ahoendgen @OskarStark @carsonbot
0