10000 [Messenger] Integration test for Postgres consumers · Issue #43631 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Integration test for Postgres consumers #43631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
derrabus opened this issue Oct 21, 2021 · 3 comments
Closed

[Messenger] Integration test for Postgres consumers #43631

derrabus opened this issue Oct 21, 2021 · 3 comments
Labels
Doctrine Help wanted Issues and PRs which are looking for volunteers to complete them. Keep open Messenger

Comments

@derrabus
Copy link
Member

Symfony version(s) affected: 5.3.9

Description
Discovered while working on #43630. The Postgres-specific logic in PostgreSqlConnection::get() is not covered by integration tests. This is why an API change between DBAL 2 and 3 was not found by the test suite.

Possible Solution
We already run integration from other components tests against a real Postgres database. We should do the same for the Messenger.
@derrabus derrabus added Doctrine Help wanted Issues and PRs which are looking for volunteers to complete them. Messenger labels Oct 21, 2021
@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@derrabus
Copy link
Member Author

Yes, let's keep the issue open.

@carsonbot carsonbot removed the Stalled label Apr 25, 2022
@Jean-Beru Jean-Beru mentioned this issue Apr 26, 2022
Merged
chalasr added a commit that referenced this issue Apr 26, 2022
@chalasr
minor #46180 [Messenger] Add PostgreSqlConnection tests (Jean-Beru)
3776e75 
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Messenger] Add PostgreSqlConnection tests

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #43631
| License       | MIT
| Doc PR        |

This PR adds integration tests on `PostgreSqlConnection::get` method to prevent bugs on Doctrine changes.

Commits
-------

1f15941 [Messenger] Add PostgreSqlConnection tests
@derrabus
Copy link
Member Author

Fixed via #46180

Sign up for free to join this conversatio 4B62 n on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doctrine Help wanted Issues and PRs which are looking for volunteers to complete them. Keep open Messenger
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@derrabus @chalasr @carsonbot
0