8000 [Validator] Url validator returns false positive · Issue #41683 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[Validator] Url validator returns false positive #41683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sidz opened this issue Jun 11, 2021 · 0 comments · Fixed by #41684
Closed

[Validator] Url validator returns false positive #41683

sidz opened this issue Jun 11, 2021 · 0 comments · Fixed by #41684
Labels
Bug Status: Needs Review Validator

Comments

@sidz
Copy link
Contributor
sidz commented Jun 11, 2021 •
edited
Loading

Symfony version(s) affected: 4.4

Description
Url Validator returns false positive result on cases:

Possible Solution
#41684
@sidz sidz added the Bug label Jun 11, 2021
@sidz sidz mentioned this issue Jun 11, 2021
Merged
fabpot added a commit that referenced this issue Aug 26, 2021
@fabpot
bug #41684 Fix Url Validator false positives (sidz)
8c674dc 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Fix Url Validator false positives

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #41683
| License       | MIT

This PR tries to fix false positive issues with a couple of variants of domain names which Url validator thinks that they are valid

Url Validator returns false positive result on cases:
- http://www.example..com
- http://www..example.com
- http://www..com
- http://.www.example.com

Commits
-------

074539d Fix Url Validator false positives
symfony-splitter pushed a commit to symfony/validator that referenced this issue Aug 26, 2021
@fabpot
bug #41684 Fix Url Validator false positives (sidz)
63b91fd 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Fix Url Validator false positives

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony/symfony#41683
| License       | MIT

This PR tries to fix false positive issues with a couple of variants of domain names which Url validator thinks that they are valid

Url Validator returns false positive result on cases:
- http://www.example..com
- http://www..example.com
- http://www..com
- http://.www.example.com

Commits
-------

074539d3c9 Fix Url Validator false positives
@fabpot fabpot closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Url Validator false positives sidz/symfony
3 participants
@fabpot @sidz @carsonbot
0