8000 [Process] ProcessTest::testTTYCommand fails on macOS in non-interactive shells · Issue #38946 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] ProcessTest::testTTYCommand fails on macOS in non-interactive shells #38946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
derrabus opened this issue Nov 1, 2020 · 1 comment
Closed

[Process] ProcessTest::testTTYCommand fails on macOS in non-interactive shells #38946

derrabus opened this issue Nov 1, 2020 · 1 comment
Labels
Bug Process

Comments

@derrabus
Copy link
Member
derrabus commented Nov 1, 2020

Symfony version(s) affected: 4.4-dev

Description
When running the Process test suite on macOS in a non-interactive shell, two tests fail with the following error message.

TTY mode requires /dev/tty to be read/writable.

This is for instance the case on GitLab's CI or when running the tests with PhpStorm.

How to reproduce
Run the Process test suite in PhpStorm.

Additional context
Discovered while working on #38620.

https://github.com/symfony/symfony/pull/38620/checks?check_run_id=1338904496#step:8:1025

There were 2 errors:

1) Symfony\Component\Process\Tests\ProcessTest::testTTYCommand
Symfony\Component\Process\Exception\RuntimeException: TTY mode requires /dev/tty to be read/writable.

/Users/runner/work/symfony/symfony/src/Symfony/Component/Process/Process.php:1075
/Users/runner/work/symfony/symfony/src/Symfony/Component/Process/Tests/ProcessTest.php:480

2) Symfony\Component\Process\Tests\ProcessTest::testTTYCommandExitCode
Symfony\Component\Process\Exception\RuntimeException: TTY mode requires /dev/tty to be read/writable.

/Users/runner/work/symfony/symfony/src/Symfony/Component/Process/Process.php:1075
/Users/runner/work/symfony/symfony/src/Symfony/Component/Process/Tests/ProcessTest.php:495

Bildschirmfoto 2020-11-01 um 18 40 55
@derrabus derrabus added the Bug label Nov 1, 2020
@Nyholm
Copy link
Member
Nyholm commented Nov 1, 2020

I'll have a look at this

@Nyholm Nyholm mentioned this issue Nov 1, 2020
Merged
nicolas-grekas added a commit that referenced this issue Nov 2, 2020
@nicolas-grekas
bug #38950 [Process] Dont test TTY if there is no TTY support (Nyholm)
ed217a1 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Process] Dont test TTY if there is no TTY support

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38946
| License       | MIT
| Doc PR        |

Commits
-------

e918e5a [Process] Dont test TTY if there is no TTY support
@chalasr chalasr closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nyholm @derrabus @chalasr
0