8000 UPGRADE-4.4 gives outdated instructions about handling RegistryInterface deprecation · Issue #38281 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

UPGRADE-4.4 gives outdated instructions about handling RegistryInterface deprecation #38281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GPHemsley opened this issue Sep 23, 2020 · 2 comments
Closed

UPGRADE-4.4 gives outdated instructions about handling RegistryInterface deprecation #38281

GPHemsley opened this issue Sep 23, 2020 · 2 comments
Labels
Bug DoctrineBridge Status: Needs Review

Comments

@GPHemsley
Copy link

(Alluded to in #34377 but not followed up on.)

Symfony\Bridge\Doctrine\RegistryInterface has been deprecated. The UPGRADE-4.4 documentation indicates that it should be replaced with Doctrine\Common\Persistence\ManagerRegistry. However, that in turn has been deprecated in favor of Doctrine\Persistence\ManagerRegistry.

The UPGRADE-4.4 documentation needs to be updated to reflect this change. (The deprecation warning issued by the code already gets this right.)
@GPHemsley GPHemsley added the Bug label Sep 23, 2020
@nicolas-grekas
Copy link
Member

Could you please send the pr you have in mind? Branch 4.4

@Matts
Copy link
Matts commented Oct 15, 2020

Will look at this.

@Matts Matts mentioned this issue Oct 15, 2020
Merged
@fabpot fabpot closed this as completed Oct 16, 2020
fabpot added a commit that referenced this issue Oct 16, 2020
@fabpot
minor #38592 [Doctrine] Reference the correct interface in the Regist…
e34241c 
…ryInterface deprecation … (Matts)

This PR was merged into the 4.4 branch.

Discussion
----------

[Doctrine] Reference the correct interface in the RegistryInterface deprecation …

…in upgrade notes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38281
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

d019d38 Reference the correct interface in the RegistryInterface deprecation in upgrade notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @nicolas-grekas @GPHemsley @xabbuh @Matts @carsonbot
0