8000 File::guessExtension() returns .mpga over .mp3 · Issue #36068 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

File::guessExtension() returns .mpga over .mp3 #36068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dwolfhub opened this issue Mar 13, 2020 · 1 comment
Closed

File::guessExtension() returns .mpga over .mp3 #36068

dwolfhub opened this issue Mar 13, 2020 · 1 comment
Labels
Mime

Comments

@dwolfhub
Copy link

To me, if someone uploads an audio/mpeg mime type, it's more likely to be an .mp3 than a .mpga

There is an old ticket #8678 that talks about how
"it is the first associated extension in the list maintained by Apache".

In my opinion, just because it is first in the list doesn't mean we should make it the default on our end. Should we consider changing the order of the list?

Happy to provide PR. Thanks
@xabbuh xabbuh added the Mime label Mar 14, 2020
@fabpot
Copy link
Member
fabpot commented Jun 23, 2020

A PR would be appreciated indeed.

@YaFou YaFou mentioned this issue Jun 23, 2020
Merged
fabpot added a commit that referenced this issue Jun 24, 2020
@fabpot
bug #37389 [HttpFondation] Change file extension of "audio/mpeg" from…
40152c3 
… "mpga" to "mp3" (YaFou)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFondation] Change file extension of "audio/mpeg" from "mpga" to "mp3"

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #36068 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | no
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

`.mp3` files are more common than `.mpga` files.

Commits
-------

76a744a [HttpFondation] Change file extension of "audio/mpeg" from "mpga" to "mp3"
@fabpot fabpot closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @xabbuh @dwolfhub
0