8000 Numerical keys used with tagged_iterator/tagged_locator reset to 0..n-1 · Issue #35953 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Numerical keys used with tagged_iterator/tagged_locator reset to 0..n-1 #35953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CthulhuDen opened this issue Mar 4, 2020 · 1 comment
Closed

Numerical keys used with tagged_iterator/tagged_locator reset to 0..n-1 #35953

CthulhuDen opened this issue Mar 4, 2020 · 1 comment
Labels
Bug Status: Needs Review

Comments

@CthulhuDen
Copy link
Contributor
CthulhuDen commented Mar 4, 2020 •
edited
Loading

Symfony version(s) affected: 5.0

Description
When !tagged_iterator have index_by set, and the corresponding tag property values are numeric, the keys actually reset to 0-based index. See repro PR

How to reproduce
See PR #35954
@CthulhuDen CthulhuDen added the Bug label Mar 4, 2020
@CthulhuDen CthulhuDen mentioned this issue Mar 4, 2020
Merged
@nicolas-grekas
Copy link
Member

Can you check if #35957 doesn't fix the issue already?

@nicolas-grekas nicolas-grekas mentioned this issue Mar 4, 2020
Merged
nicolas-grekas added a commit that referenced this issue Mar 5, 2020
@nicolas-grekas
bug #35957 [DI] ignore extra tags added by autoconfiguration in Prior…
3801ddc 
…ityTaggedServiceTrait (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DI] ignore extra tags added by autoconfiguration in PriorityTaggedServiceTrait

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35916, Fix #35953
| License       | MIT
| Doc PR        | -

Commits
-------

09770aa [DI] ignore extra tags added by autoconfiguration in PriorityTaggedServiceTrait
nicolas-grekas added a commit that referenced this issue Mar 12, 2020
@nicolas-grekas
minor #35954 Add test for tagged iterator with numeric index (Denis Y…
b913b86 
…uzhanin)

This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead.

Discussion
----------

Add test for tagged iterator with numeric index

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| License       | MIT

This is just a new test case for bug in issue #35953

Commits
-------

7aa4e10 Add test for tagged iterator with numeric index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @CthulhuDen @carsonbot
0