8000 Documentation error about setException method on ExceptionEvent · Issue #35686 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Documentation error about setException method on ExceptionEvent #35686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dacheng-gao opened this issue Feb 12, 2020 · 0 comments · Fixed by #35687
Closed

Documentation error about setException method on ExceptionEvent #35686

dacheng-gao opened this issue Feb 12, 2020 · 0 comments · Fixed by #35687

Comments

@dacheng-gao
Copy link
dacheng-gao commented Feb 12, 2020 •
edited
Loading

Symfony version(s) affected: 5.0.4

Description

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Event/ExceptionEvent.php#L24

How to reproduce

Possible Solution

Rename setException() to setThrowable().

Additional context
@dacheng-gao dacheng-gao mentioned this issue Feb 12, 2020
Merged
@fabpot fabpot closed this as completed Feb 12, 2020
fabpot added a commit that referenced this issue Feb 12, 2020
@fabpot
minor #35687 [HttpKernel] Fix method name in doc comments (successgo)
fb14669 
This PR was merged into the 5.0 branch.

Discussion
----------

[HttpKernel] Fix method name in doc comments

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #35686  <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        |  <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

5888566 [HttpKernel] Fix method name in doc comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HttpKernel] Fix method name in doc comments
2 participants
@fabpot @dacheng-gao
0