8000 [MonologBridge] ServerLogHandler is incompatible with Monolog 2.0 · Issue #34520 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[MonologBridge] ServerLogHandler is incompatible with Monolog 2.0 #34520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jderusse opened this issue Nov 22, 2019 · 2 comments
Closed

[MonologBridge] ServerLogHandler is incompatible with Monolog 2.0 #34520

jderusse opened this issue Nov 22, 2019 · 2 comments
Labels
Bug MonologBridge Status: Needs Review

Comments

@jderusse
Copy link
Member

Because Monolog removes the protected attribute $processors in AbstractHandler

  - Updating monolog/monolog (1.25.2 => 2.0.1): Loading from cache                          
  - Updating symfony/monolog-bridge (v4.4.0 => v5.0.0): Loading from cache                  

In ServerLogHandler.php line 106:                                            
                                                                                            
  [ErrorException]                                                                          
  Notice: Undefined property: Symfony\Bridge\Monolog\Handler\ServerLogHandler::$processors

I don't have time to dig right now, but can check it later next week.
@xabbuh xabbuh mentioned this issue Nov 22, 2019
Closed
@xabbuh
Copy link
Member
xabbuh commented Nov 22, 2019

see #34521

@xabbuh xabbuh reopened this Nov 22, 2019
@nicolas-grekas
Copy link
Member

/cc @lyrixx you might want to have a look :)

@jderusse jderusse mentioned this issue Nov 28, 2019
Merged
nicolas-grekas added a commit that referenced this issue Nov 29, 2019
@nicolas-grekas
bug #34697 [MonologBridge] Fix compatibility of ServerLogHandler with…
5a30793 
… Monolog 2 (jderusse)

This PR was merged into the 5.0 branch.

Discussion
----------

[MonologBridge] Fix compatibility of ServerLogHandler with Monolog 2

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #34520
| License       | MIT
| Doc PR        | NA

This is an alternative to #34521 that keep compatibility with "processors" and "formaters".

Commits
-------

bdb10f7 Fix compatibility with Monolog 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug MonologBridge Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nicolas-grekas @jderusse @xabbuh @carsonbot
0