8000 [RFC] Enable AutoAliasServicePass compiler pass by default · Issue #34194 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[RFC] Enable AutoAliasServicePass compiler pass by default #34194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
X-Coder264 opened this issue Oct 30, 2019 · 1 comment · Fixed by #34884
Closed

[RFC] Enable AutoAliasServicePass compiler pass by default #34194

X-Coder264 opened this issue Oct 30, 2019 · 1 comment · Fixed by #34884
Labels
DependencyInjection RFC RFC = Request For Comments (proposals about features that you want to be discussed)

Comments

@X-Coder264
Copy link
Contributor
X-Coder264 commented Oct 30, 2019 •
edited
Loading

Why isn't the AutoAliasServicePass compiler pass enabled by default?

It was added in #12526 and even there some people are asking the same question.

I needed this exact functionality and I found this compiler pass by going through all compiler passes in the dependency injection component and only later I saw the little mention about it (and how it has to be manually added to the container) in the documentation where the auto_alias tag was documented.
@X-Coder264 X-Coder264 changed the title Enable AutoAliasServicePass compiler pass by default [RFC] Enable AutoAliasServicePass compiler pass by default Oct 30, 2019
@javiereguiluz javiereguiluz added DependencyInjection RFC RFC = Request For Comments (proposals about features that you want to be discussed) labels Oct 31, 2019
@nicolas-grekas
Copy link
Member

I'd suggest sending a PR doing so to trigger the discussion.

@X-Coder264 X-Coder264 mentioned this issue Dec 8, 2019
Merged
@fabpot fabpot closed this as completed Feb 5, 2020
fabpot added a commit that referenced this issue Feb 5, 2020
@fabpot
feature #34884 [DI] Enable auto alias compiler pass by default (X-Cod…
3bcf8cb 
…er264)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[DI] Enable auto alias compiler pass by default

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  |
| Deprecations? | no
| Tickets       | Fix #34194
| License       | MIT
| Doc PR        |

I'm sending this PR to trigger a discussion as @nicolas-grekas suggested in #34194

I'm using this quite a lot in one of my applications and I don't see any reasons why it shouldn't be enabled by default.

Commits
-------

4fde517 Enable auto alias compiler pass by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DependencyInjection RFC RFC = Request For Comments (proposals about features that you want to be discussed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DI] Enable auto alias compiler pass by default X-Coder264/symfony
4 participants
@fabpot @javiereguiluz @nicolas-grekas @X-Coder264
0