8000 Could assertSelectorTextContains return current value in WebTestCase? · Issue #33551 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

Could assertSelectorTextContains return current value in WebTestCase? #33551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sabat24 opened this issue Sep 11, 2019 · 4 comments · Fixed by #39856
Closed

Could assertSelectorTextContains return current value in WebTestCase? #33551

sabat24 opened this issue Sep 11, 2019 · 4 comments · Fixed by #39856
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) FrameworkBundle Stalled

Comments

@sabat24
Copy link
sabat24 commented Sep 11, 2019 •
edited
Loading

Right now when test fails there is information about selector and expected value, but there is no information about actual value from test.

Matches selector "#selector" and has a node matching selector "#selector" with content containing "expected_value"

I would like to now, what was the actual value of the test which was found in that #selector to get more details why it failed.
@xabbuh xabbuh added DX DX = Developer eXperience (anything that improves the experience of using Symfony) FrameworkBundle labels Sep 11, 2019
@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@carsonbot
Copy link

Friendly ping? Should this still be open? I will close if I don't hear anything.

@carsonbot
Copy link

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

@xabbuh xabbuh mentioned this issue Jan 16, 2021
Merged
@xabbuh
Copy link
Member
xabbuh commented Jan 16, 2021

see #39856

@xabbuh xabbuh mentioned this issue Feb 26, 2021
Closed
fabpot added a commit that referenced this issue Aug 26, 2021
@fabpot
bug #39856 [DomCrawler] improve failure messages of the CrawlerSelect…
3ff5db6 
…orTextContains constraint (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[DomCrawler] improve failure messages of the CrawlerSelectorTextContains constraint

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33551, #37757
| License       | MIT
| Doc PR        |

Commits
-------

ba451ab improve failure messages of the CrawlerSelectorTextContains constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) FrameworkBundle Stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DomCrawler] improve failure messages of the CrawlerSelectorTextContains constraint xabbuh/symfony
3 participants
@xabbuh @sabat24 @carsonbot
0