8000 Symfony 4.3 upgrade note lacks upgrade path for AbstractAuthenticationListener · Issue #32339 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Symfony 4.3 upgrade note lacks upgrade path for AbstractAuthenticationListener #32339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XWB opened this issue Jul 3, 2019 · 2 comments
Closed

Symfony 4.3 upgrade note lacks upgrade path for AbstractAuthenticationListener #32339

XWB opened this issue Jul 3, 2019 · 2 comments
Labels
Deprecation DX DX = Developer eXperience (anything that improves the experience of using Symfony) Security

Comments

@XWB
Copy link
Contributor
XWB commented Jul 3, 2019

In addition to #32120

Symfony 4.3 throws the following deprecation notice:

The "Symfony\Component\Security\Http\Firewall\AbstractAuthenticationListener" class is considered internal since Symfony 4.3. It may change without further notice. You should not use it from "HWI\Bundle\OAuthBundle\Security\Http\Firewall\OAuthListener".

However, the upgrade document doesn't list the AbstractAuthenticationListener. What would be the best approach to get rid of this deprecation notice? Do we really need to copy all functionality from AbstractAuthenticationListener into our custom OAuthListener?
@XWB XWB mentioned this issue Jul 3, 2019
Closed
@xabbuh xabbuh added Deprecation DX DX = Developer eXperience (anything that improves the experience of using Symfony) Security labels Jul 3, 2019
@linaori
Copy link
Contributor
linaori commented Jul 3, 2019

This is not a deprecation as far as I can see, it's changed to an internal class. My best guess to solve this is for that bundle to create their own version of this class and ship it along. It wouldn't surprise me if this class would be removed at some point as the SimpleFormAuthenticationListener and UsernamePasswordFormAuthenticationListener implementations are not the recommended way of configuring authentication anymore. (simple_form and form_login respectively I believe).

I think this upgrade note would be beneficial though.

@chalasr
Copy link
Member
chalasr commented Jul 29, 2019

The flag has been removed in #32662, upgrading to 4.3.3 should make the notice disappear.

@chalasr chalasr closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecation DX DX = Developer eXperience (anything that improves the experience of using Symfony) Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@XWB @linaori @xabbuh @chalasr
0