8000 UPGRADE to Symfony 4.3 missing helpful documentation · Issue #32120 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

UPGRADE to Symfony 4.3 missing helpful documentation #32120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rbaarsma opened this issue Jun 20, 2019 · 2 comments
Closed

UPGRADE to Symfony 4.3 missing helpful documentation #32120

rbaarsma opened this issue Jun 20, 2019 · 2 comments
Labels
Status: Reviewed

Comments

@rbaarsma
Copy link
Contributor

I had lots of deprecation warnings for twig engine being deprecated and other twig-related stuff that I wasn't using in my code. I have a pretty simple Symfony 4.2 (standardly installed with symfony flex) project and had a hard time locating the source of the problem.

Turns out that in the framework.yaml file (config/packages dir), from Symfony 4.2 there's still this part:

    templating:
        engines:
            - 'twig'

Removing that solved lots of deprecation issues.

Would be great if this can be added to the UPGRADE-4.3.md document
@Simperfit
Copy link
Contributor

@rbaarsma I think this is missing from #21035 do you want to add it ?

Status: Reviewed

@robob4him
Copy link

I had lots of deprecation warnings for twig engine being deprecated and other twig-related stuff that I wasn't using in my code. I have a pretty simple Symfony 4.2 (standardly installed with symfony flex) project and had a hard time locating the source of the problem.

Turns out that in the framework.yaml file (config/packages dir), from Symfony 4.2 there's still this part:

    templating:
        engines:
            - 'twig'

Removing that solved lots of deprecation issues.

Would be great if this can be added to the UPGRADE-4.3.md document

Many thanks, @rbaarsma. That was driving me crazy.

@xabbuh xabbuh mentioned this issue Jun 28, 2019
Merged
fabpot added a commit that referenced this issue Jul 3, 2019
@fabpot
minor #32267 [FrameworkBundle] deprecate the framework.templating opt…
51f01bd 
…ion (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] deprecate the framework.templating option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #32120
| License       | MIT
| Doc PR        |

The config node has already been removed in the `master` branch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix.

Commits
-------

ba241ce deprecate the framework.templating option
@fabpot fabpot closed this as completed Jul 3, 2019
@XWB XWB mentioned this issue Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @robob4him @rbaarsma @Simperfit @carsonbot
0