8000 [Messenger] Redis Transport does not create a stream · Issue #31791 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Redis Transport does not create a stream #31791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
desmax opened this issue Jun 2, 2019 · 5 comments
Closed

[Messenger] Redis Transport does not create a stream #31791

desmax opened this issue Jun 2, 2019 · 5 comments
Labels
Bug Messenger Status: Needs Review
Milestone
4.3

Comments

@desmax
Copy link
Contributor
desmax commented Jun 2, 2019

Symfony version(s) affected: 4.3

Description
Redis transport does not create a stream and when messenger tries to consume messages it fails with NOGROUP No such key 'msgssls' or consumer group 'symfony' in XREADGROUP with GROUP option

although line $this->connection->xgroup('CREATE', $this->stream, $this->group, 0, true); is executed in Symfony\Component\Messenger\Transport\RedisExt\Connection
no command is issued in redis.

If I create stream manually like this "XGROUP" "CREATE" "msgssls" "symfony" "0" "MKSTREAM" it processes 1 message and then gives Segmentation fault.

This works fine on my mac, but fails on debian server.
@javiereguiluz javiereguiluz added this to the 4.3 milestone Jun 2, 2019
@desmax
Copy link
Contributor Author
desmax commented Jun 2, 2019

if I remove last argument from $this->connection->xgroup('CREATE', $this->stream, $this->group, 0, true); segmentation goes away. But I still have to create stream manually.

what does that argument mean? I don't see it in the arguments list

@chalasr
Copy link
Member
chalasr commented Jun 2, 2019

What is the version of redis and phpredis installed on your debian server?

@desmax
Copy link
Contributor Author
desmax commented Jun 2, 2019

@chalasr redis is 5.0.3, php and php-redis extension is 7.3.6

@chalasr
Copy link
Member
chalasr commented Jun 5, 2019

Ok, same issue, unable to upgrade to 4.3 in production. Probably related to oerdnj/deb.sury.org#1184

@chalasr
Copy link
Member
chalasr commented Jun 5, 2019 •
edited
Loading

Confirmed, the transport works fine with phpredis 4.3 but produces segfault with phpredis 4.2. I'm going to add a check in the transport.
And we 9D95 will need to wait for oerdnj/deb.sury.org#1184, +1 welcome there.

@chalasr chalasr mentioned this issue Jun 5, 2019
Merged
@fabpot fabpot closed this as completed Jun 5, 2019
fabpot added a commit that referenced this issue Jun 5, 2019
@fabpot
bug #31872 [Messenger] Add missing runtime check for ext redis versio…
a6b306d 
…n (chalasr)

This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Add missing runtime check for ext redis version

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31791
| License       | MIT
| Doc PR        | n/a

Lower versions lead to segmentation faults.

Commits
-------

07603da [Messenger] Add runtime check for ext redis version
@chalasr chalasr mentioned this issue Jul 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @desmax @chalasr @carsonbot
0