8000 PhpunitBridge tags declaring wrong PHP support should to be dropped or changed · Issue #30709 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

PhpunitBridge tags declaring wrong PHP support should to be dropped or changed #30709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ostrolucky opened this issue Mar 26, 2019 · 5 comments
Closed

PhpunitBridge tags declaring wrong PHP support should to be dropped or changed #30709

ostrolucky opened this issue Mar 26, 2019 · 5 comments
Labels
Bug PhpUnitBridge Status: Needs Review

Comments

@ostrolucky
Copy link
Contributor

There are symfony/phpunit-bridge 4.2.4 and 3.4.23 versions which declare support for PHP 5.3 but use PHP 5.4 syntax. Even when new version which fixes this will be released, this will not fix the issue, because if you test on PHP 5.3/5.4 and have

"require-dev": {"symfony/phpunit-bridge": "^3.0|4.0"}

composer will skip installing 4.2.5/3.4.24 and keep installing faulty version.

I suggest to exceptionally drop these faulty tags. Fortunately, there are no significant changes:

symfony/phpunit-bridge@v3.4.22...v3.4.23
symfony/phpunit-bridge@v4.2.3...v4.2.4
@xabbuh
Copy link
Member
xabbuh commented Mar 26, 2019

I am not sure I understand. Why would Composer not install 3.4.24 or 4.2.4?

@ostrolucky
Copy link
Contributor Author
ostrolucky commented Mar 26, 2019 •
edited
Loading

Because php requirement will be fixed in these versions. Composer doesn't install dependencies for which you don't fullfill platform criteria.

@xabbuh
Copy link
Member
xabbuh commented Mar 26, 2019

But we don't increase the required PHP version for these releases so there's no platform requirement preventing the installation. We only made the mistake in some releases to have PHP 5.4+ code in versions of the bridge that must be compatible with PHP 5.3.

@ostrolucky
Copy link
Contributor Author

there's no platform requirement preventing the installation

What I am reporting is opposite. Installation of 4.2.4+/3.4.23+ shlould be prevented on PHP 5.3 but it is not. Fixing requirement in new version will not fix it for already released tags.

@ostrolucky
Copy link
Contributor Author

After discussion with @xabbuh on slack, what I didn't realize is that requirement was fixed in master only, not in 3.4, 4.2 branches. And <4.3 branches are supposed to have PHP 5.3 support (#29623 (comment)), so seems solution should be to revert short array commits there, no need to change old tags.

@xabbuh xabbuh added the Bug label Mar 26, 2019
@xabbuh xabbuh mentioned this issue Mar 26, 2019
Merged
fabpot added a commit that referenced this issue Mar 27, 2019
@fabpot
minor #30714 [PhpUnitBridge] fix PHP 5.3 compatibility (xabbuh)
06e657a 
This PR was merged into the 4.2 branch.

Discussion
----------

[PhpUnitBridge] fix PHP 5.3 compatibility

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30709
| License       | MIT
| Doc PR        |

Commits
-------

dccf1ee fix PHP 5.3 compatibility
@xabbuh xabbuh closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @ostrolucky @xabbuh @carsonbot
0