8000 [Validator] Add the missing translations for the Brazilian Portuguese ("pt_BR") locale · Issue #30182 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Add the missing translations for the Brazilian Portuguese ("pt_BR") locale #30182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Feb 12, 2019 · 2 comments
Closed

[Validator] Add the missing translations for the Brazilian Portuguese ("pt_BR") locale #30182

javiereguiluz opened this issue Feb 12, 2019 · 2 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone
3.4

Comments

@javiereguiluz
Copy link
Member
javiereguiluz commented Feb 12, 2019 •
edited
Loading

IMPORTANT: this issue is reserved for new contributors, because we want to give the opportunity to people who want to contribute to Symfony but never found the right issue to do that.

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!

Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.pt_BR.xlf file is missing the following translations compared to the original English file:

<trans-unit id="82">
    <source>Error</source>
    <target>...</target>
</trans-unit>
<trans-unit id="83">
    <source>This is not a valid UUID.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="86">
    <source>This value should be valid JSON.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.
@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@sousatg
Copy link
sousatg commented Feb 12, 2019

I can do this :)

@felipyamorim
Copy link
Contributor

I can do too, of course, if @sousatg does not.

felipyamorim added a commit to felipyamorim/symfony that referenced this issue Feb 19, 2019
@felipyamorim
[Validator] Added missing translations pt_BR
19ca344 
| Q | A |
|--|--|
| Branch? | 3.4 |
| Bug fix? |no|
|New feature?	|no|
|BC breaks?	|no|
|Deprecations?	|no|
|Tests pass?	|yes|
|Fixed tickets	|symfony#30182|
|License	|MIT|

Added missing translations.
@felipyamorim felipyamorim mentioned this issue Feb 19, 2019
Merged
nicolas-grekas added a commit that referenced this issue Feb 20, 2019
@nicolas-grekas
minor #30308 [Validator] Added missing translations pt_BR (felipyamorim)
df0fc5e 
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Added missing translations pt_BR

| Q | A |
|--|--|
| Branch? | 3.4
| Bug fix? | no
|New feature?	| no
|BC breaks?	| no
|Deprecations?	|no
|Tests pass?	| yes
|Fixed tickets	| #30182
|License	| MIT

Added missing translations.

Commits
-------

19ca344 [Validator] Added missing translations pt_BR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
4 participants
@javiereguiluz @nicolas-grekas @sousatg @felipyamorim
0