8000 Twig icon in profiler is active even without templates rendered · Issue #30033 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Twig icon in profiler is active even without templates rendered #30033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garak opened this issue Jan 30, 2019 · 0 comments
Closed

Twig icon in profiler is active even without templates rendered #30033

garak opened this issue Jan 30, 2019 · 0 comments
Assignees
@javiereguiluz
Labels
Bug Status: Needs Review WebProfilerBundle
Milestone
3.4

Comments

@garak
Copy link
Contributor
garak commented Jan 30, 2019

Symfony version(s) affected: 4.2.2

Description
A couple of images should explain the problem.
This is profiler I see:
schermata da 2019-01-30 09-29-13
Then, I click on Twig icon and I get this:
schermata da 2019-01-30 09-30-30
So, the Twig icon is active (e.g. not in gray) even when profiled request rendered no templates.
This is inconsistent with other profiler icons, that are grey when no info is collected and active otherwise.

How to reproduce
Just call a route in your application when Twig is not involved, e.g. an action returning a JsonResponse.

Possible Solution
Likely some check is missing.
@javiereguiluz javiereguiluz self-assigned this Jan 30, 2019
@javiereguiluz javiereguiluz mentioned this issue Jan 30, 2019
Merged
@javiereguiluz javiereguiluz added this to the 3.4 milestone Jan 30, 2019
nicolas-grekas added a commit that referenced this issue Jan 30, 2019
@nicolas-grekas
bug #30037 Disable Twig in the profiler menu when Twig is not used (j…
fb43484 
…aviereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Disable Twig in the profiler menu when Twig is not used

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30033
| License       | MIT
| Doc PR        | -

Commits
-------

b474081 Disable Twig in the profiler menu when Twig is not used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javiereguiluz javiereguiluz

Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
5 participants
@javiereguiluz @garak @nicolas-grekas @xabbuh @carsonbot
0