8000 [symfony/console] Tables using "box" style with colspan break layout · Issue #28532 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[symfony/console] Tables using "box" style with colspan break layout #28532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhukster opened this issue Sep 21, 2018 · 2 comments
Closed

[symfony/console] Tables using "box" style with colspan break layout #28532

rhukster opened this issue Sep 21, 2018 · 2 comments
Labels
Bug Console Status: Needs Review

Comments

@rhukster
Copy link

Symfony version(s) affected: 4.1.x

Description
When using the box or box-double Table styling, regular tables are rendered fine, but tables with nested TableCells using colspan break the layout.

How to reproduce

Using this code from the docs (plus a style):

$table = new Table($output);
$table->setStyle('box');
$table
    ->setHeaders(array('ISBN', 'Title', 'Author'))
    ->setRows(array(
        array('99921-58-10-7', 'Divine Comedy', 'Dante Alighieri'),
        new TableSeparator(),
        array(new TableCell('This value spans 3 columns.', array('colspan' => 3))),
    ))
;
$table->render();

results in this:

monosnap-2018-09-20-20-02-10 image

compared to this with the default styling:

monosnap-2018-09-20-20-02-34 image
@rhukster rhukster changed the title Console tables using box style with colspan break layout [console] tables using box style with colspan break layout Sep 21, 2018
@rhukster rhukster changed the title [console] tables using box style with colspan break layout [symfony/console] tables using box style with colspan break layout Sep 21, 2018
@rhukster rhukster changed the title [symfony/console] tables using box style with colspan break layout [symfony/console] Tables using "box" style with colspan break layout Sep 21, 2018
@ro0NL ro0NL mentioned this issue Sep 21, 2018
Merged
@ro0NL
Copy link
Contributor
ro0NL commented Sep 21, 2018

See #28548

@rhukster
Copy link
Author

Nice! Thanks for the quick response!

nicolas-grekas added a commit that referenced this issue Sep 22, 2018
@nicolas-grekas
bug #28548 [Console] Fixed boxed table style with colspan (ro0NL)
2c8c6f7 
This PR was merged into the 2.8 branch.

Discussion
----------

[Console] Fixed boxed table style with colspan

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28532
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

a67ff2a [Console] Fixed boxed table style with colspan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @nicolas-grekas @ro0NL @rhukster @carsonbot
0