8000 ide setting on path replace fails again · Issue #26917 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

ide setting on path replace fails again #26917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Arkemlar opened this issue Apr 13, 2018 · 2 comments
Closed

ide setting on path replace fails again #26917

Arkemlar opened this issue Apr 13, 2018 · 2 comments

Comments

@Arkemlar
Copy link
Arkemlar commented Apr 13, 2018 •
edited
Loading
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? yes
Symfony version 4.0.7

Attention! This issue relates only for unhandled exception debug window which shows up for exceptions thrown by PHP like \ErrorException and handled by set_error_handler mechanism. These are exceptions based on FatalErrorException class. Exceptions handled by symfony/source code and displayed by kernel.exception event is not related. I wrote this issue text shown below before I relised this difference, but it is still relevant for unhandled exceptions.

I did everything as described in this topic. I use Ubuntu & PhpStorm & Chrome.
This path replacing mechanics not working for me at all.
I checked out this issue but it wont helped me neither.
I did a couple of tries which I generalised to this two scenarios:
First try:
framework.yml: ide: "phpstorm://open?file=%%f&line=%%l&/usr/local/>/var/www/project_name/"
php.ini: xdebug.file_link_format = ""
Result: not a phpstorm link
image
Second try:
no ide key in framework.yml
php.ini: xdebug.file_link_format = "phpstorm://open?file=%f&line=%l&/usr/local/>/var/www/project_name/"
Result its a link
image
BUT the link is phpstorm://open?file=/usr/local/app/src/Entity/WhatEverFile.php&line=205&/usr/local/>/var/www/project_name/ wich results to non existent file error in PhpStorm - it tries to open /usr/local/app/src/Entity/WhatEverFile.php file.

I have tried phpstorm://open?url=file://%f&line=%l&/usr/local/>/var/www/project_name/ format just in case.. but hopeless.
@nicolas-grekas
Copy link
Member

Hi @Arkemlar thanks for the report.
Would to like to submit a fix?

@nicolas-grekas nicolas-grekas mentioned this issue Apr 27, 2018
Merged
@nicolas-grekas
Copy link
Member

Can you please check #27074 and report if it fixes your issue?

nicolas-grekas added a commit that referenced this issue Apr 30, 2018
@nicolas-grekas
bug #27074 [Debug][WebProfilerBundle] Fix setting file link format (l…
0bfd126 
…yrixx, nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Debug][WebProfilerBundle] Fix setting file link format

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | ,p
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26917
| License       | MIT
| Doc PR        | -

Commits
-------

a4a1645 [Debug][WebProfilerBundle] Fix setting file link format
620f90d [Debug] Fixed the formatPath when a custom fileLinkFormat is defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolas-grekas @Arkemlar
0