8000 Password authentication not correct · Issue #26525 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Password authentication not correct #26525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonRininsland opened this issue Mar 14, 2018 · 1 comment
Closed

Password authentication not correct #26525

SimonRininsland opened this issue Mar 14, 2018 · 1 comment
Labels
Bug Ldap Status: Needs Review

Comments

@SimonRininsland
Copy link
SimonRininsland commented Mar 14, 2018 •
edited by javiereguiluz
Loading

symfony/src/Symfony/Component/Security/Core/Authentication/Provider/LdapBindAuthenticationProvider.php

Line 77 in 9e82562

if ('' === $password) {

We found an Issue with this Line. If removing the password input field in the DOM Symfony gets a null here. But NULL compared to '' is not true - so it seems okay and throws no Error.
Checking the password with an "empty($password) === true)" solves the Issue.
@javiereguiluz javiereguiluz changed the title Passwort authentication not correct Password authentication not correct Mar 14, 2018
@ismail1432
Copy link
Contributor
ismail1432 commented Mar 18, 2018 •
edited
Loading

I don't try to reproduce the bug, but IMHO in this case the condition if(empty($password)) make more sense for me see doc for refresh memory 😄 There is the PR but I can let @SimonRininsland resolves it if he wants.
Cheers Guys

@ismail1432 ismail1432 mentioned this issue Mar 18, 2018
Closed
nicolas-grekas added a commit that referenced this issue Mar 22, 2018
@nicolas-grekas
bug #26589 [Ldap] cast to string when checking empty passwords (ismai…
2f5bd18 
…l1432)

This PR was submitted for the master branch but it was squashed and merged into the 2.8 branch instead (closes #26589).

Discussion
----------

[Ldap] cast to string when checking empty passwords

| Q             | A
| ------------- | ---
| Branch?       | master for features / 2.7 up to 4.0 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26525  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Quick fix condition that solved the issue.
-->

Commits
-------

f276989 [Ldap] cast to string when checking empty passwords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Ldap Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @nicolas-grekas @SimonRininsland @ismail1432 @carsonbot
0