8000 [Twig] Whitespace control modifier missing in form layouts · Issue #25252 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Twig] Whitespace control modifier missing in form layouts #25252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kubawerlos opened this issue Dec 1, 2017 · 1 comment
Closed

[Twig] Whitespace control modifier missing in form layouts #25252

kubawerlos opened this issue Dec 1, 2017 · 1 comment
Labels
Bug Form Status: Needs Review TwigBridge

Comments

@kubawerlos
Copy link
Contributor
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version >=2.7

There is a single whitespace control modifier missing in form layouts, so new line from here: form_div_layout.html.twig#L351 would be present in e.g. CollectionType Field in data-prototype attribute.
@Simperfit
Copy link
Contributor

Do you want to provide a PR for this?

@kubawerlos kubawerlos mentioned this issue Dec 2, 2017
Merged
fabpot added a commit that referenced this issue Dec 4, 2017
@fabpot
bug #25278 Fix for missing whitespace control modifier in form layout…
783cd69 
… (kubawerlos)

This PR was merged into the 2.7 branch.

Discussion
----------

Fix for missing whitespace control modifier in form layout

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25252
| License       | MIT
| Doc PR        | -

That single missing whitespace control modifier results in e.g. new line in `data-prototype` attribute when using CollectionType field type in form.

Commits
-------

369075a Fix for missing whitespace control modifier in form layout
@fabpot fabpot closed this as completed Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Needs Review TwigBridge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @xabbuh @Simperfit @kubawerlos @carsonbot
0