[YAML] Nested array incorrectly parsed #25239

ro0NL · 2017-12-01T09:37:45Z

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	3.3.13

Given

$yaml = <<<YAML
services:
    foo:
        class: Foo
        arguments: ['@bar', '@baz', [
            '@qux',
            '%foo%',
            bar,
            123
        ]]

YAML;

dump(Symfony\Component\Yaml\Yaml::parse($yaml));

I get

Malformed inline YAML string: ['@bar', '@baz', [ '@qux', '%foo%', bar, 123 at line 8 (near " 123").

While this is valid at http://www.yamllint.com/

To make it work in SF i had to change the last lines to 123]]

cc @xabbuh :-)

The text was updated successfully, but these errors were encountered:

xabbuh · 2017-12-01T09:56:33Z

Do you know if this worked in a previous version?

ro0NL · 2017-12-01T10:19:20Z

For 2.7.38 i get

Malformed inline YAML string: ['@bar', '@baz', [ at line 4 (near "arguments: ['@bar', '@baz', [").

xabbuh · 2017-12-05T09:07:10Z

Thanks for the response. I think this needs to be fixed in 3.3 as this is the oldest maintained version that has support for multi-line structures. However, we would still need to rewrite some of its logic. You can take a first look at https://github.com/symfony/symfony/compare/3.3...xabbuh:issue-25239?expand=1 which still needs some work to cover certain edge cases.

Simperfit · 2019-04-29T17:34:23Z

@xabbuh did you advanced on that ? is it fixed already ?

xabbuh · 2019-04-29T17:54:46Z

IIRC it's the same as #25379 (comment)

xabbuh · 2019-09-21T10:00:57Z

Can you confirm that #33658 will solve your issue?

ro0NL · 2019-09-21T10:54:11Z

i dont have the actual code at hand anymore, if the reproducer here now passes im fine :)

xabbuh · 2019-09-21T11:54:38Z

@ro0NL I just tried your example with the following script:

require __DIR__.'/vendor/autoload.php';

use Symfony\Component\Yaml\Yaml;

$yaml = <<<YAML
services:
    foo:
        class: Foo
        arguments: ['@bar', '@baz', [
            '@qux',
            '%foo%',
            bar,
            123
        ]]

YAML;

dump(Yaml::parse($yaml));

The result is this:

array:1 [
  "services" => array:1 [
    "foo" => array:2 [
      "class" => "Foo"
      "arguments" => array:3 [
        0 => "@bar"
        1 => "@baz"
        2 => array:4 [
          0 => "@qux"
          1 => "%foo%"
          2 => "bar"
          3 => 123
        ]
      ]
    ]
  ]
]

… (xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] fix parsing inline YAML spanning multiple lines | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #25239 #25379 #31333 | License | MIT | Doc PR | Commits ------- 85a5c31 fix parsing inline YAML spanning multiple lines

xabbuh added Bug Yaml labels Dec 1, 2017

carsonbot added the Status: Needs Review label Dec 1, 2017

xabbuh mentioned this issue Dec 8, 2017

YAML parser: No Escaping of single quotes before newline? #25379

Closed

xabbuh mentioned this issue Feb 19, 2019

[YAML] Bogus { } is not treated as an error #30298

Closed

xabbuh mentioned this issue Aug 6, 2019

Comments confuse the YAML parser #32952

Closed

xabbuh mentioned this issue Sep 21, 2019

[Yaml] fix parsing inline YAML spanning multiple lines #33658

Merged

fabpot closed this as completed Sep 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[YAML] Nested array incorrectly parsed #25239

[YAML] Nested array incorrectly parsed #25239

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!