8000 If you answer server:start with N, it starts anyway. · Issue #24879 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

If you answer server:start with N, it starts anyway. #24879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SerkanYildiz opened this issue Nov 9, 2017 · 3 comments
Closed

If you answer server:start with N, it starts anyway. #24879

SerkanYildiz opened this issue Nov 9, 2017 · 3 comments
Labels
Bug Status: Needs Review WebServerBundle

Comments

@SerkanYildiz
Copy link
Contributor
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.3.10

When you run php bin/console server:start and you don't have installed pcntl, the console asks you
"Do you want to execute server:run immediately? [yN]:".

If you answer this with 'N' or 'n', it just continues and starts the server. You have to leave it empty to stop the command.

If it's ok, I am candidate to fix this and make my first PR to Symfony.
@chalasr
Copy link
Member
chalasr commented Nov 9, 2017

👍 the command should use $io->confirm('...') instead of $io->ask('... [yN]'), PR welcomed.

@chalasr
Copy link
Member
chalasr commented Nov 9, 2017

PR should be submitted against the 3.3 branch.

@SerkanYildiz
Copy link
Contributor Author

Thanks! Indeed I already found it. I just need to change ask to confirm. Will send PR within minutes.

@SerkanYildiz SerkanYildiz mentioned this issue Nov 9, 2017
Closed
fabpot added a commit that referenced this issue Nov 9, 2017
@fabpot
bug #24881 [WebserverBundle] fixed the bug that caused that the webse…
ead2a1a 
…rver would … (Serkan Yildiz)

This PR was squashed before being merged into the 3.3 branch (closes #24881).

Discussion
----------

[WebserverBundle] fixed the bug that caused that the webserver would …

Fixed the bug that caused that the webserver would start anyway even you said N.

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24879
| License       | MIT
| Doc PR        | /

Commits
-------

c256782 [WebserverBundle] fixed the bug that caused that the webserver would …
@fabpot fabpot closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review WebServerBundle
Projects
None yet
3AF5
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @SerkanYildiz @chalasr @carsonbot
0