8000 HTML5 input datetime should be rendered as type "datetime-local" instaed of "datetime" · Issue #24307 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

HTML5 input datetime should be rendered as type "datetime-local" instaed of "datetime" #24307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Shoplifter opened this issue Sep 24, 2017 · 0 comments
Closed

HTML5 input datetime should be rendered as type "datetime-local" instaed of "datetime" #24307

Shoplifter opened this issue Sep 24, 2017 · 0 comments
Labels
Bug Form Status: Needs Review

Comments

@Shoplifter
Copy link
Contributor
Shoplifter commented Sep 24, 2017 •
edited
Loading
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.3.9

<input type="datetime"> has been removed from WHATWG HTML
see whatwg/html#336 and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime .

Instaed browsers implement and developers are encouraged to use <input type="datetime-local">

https://github.com/symfony/form/blob/master/Extension/Core/Type/DateTimeType.php#L196
@Shoplifter Shoplifter changed the title HTML5 input datetime should be rendered as typ "datetime-local" instaed of "datetime" HTML5 input datetime should be rendered as type "datetime-local" instaed of "datetime" Sep 24, 2017
@pierredup pierredup mentioned this issue Oct 2, 2017
Merged
fabpot added a commit that referenced this issue Mar 20, 2018
@fabpot
bug #24401 [Form] Change datetime to datetime-local for HTML5 datetim…
0877bf6 
…e input (pierredup)

This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Change datetime to datetime-local for HTML5 datetime input

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | Unknown
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24307
| License       | MIT
| Doc PR        | N/A

Change the input type from datetime to datetime-local for HTML5 date input (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime)

Commits
-------

802c67c Change datetime input to datetime-local
@fabpot fabpot closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @Shoplifter @carsonbot
0