10000 Absolute url twig extension not working with query strings only · Issue #23260 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Absolute url twig extension not working with query strings only #23260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexander-schranz opened this issue Jun 22, 2017 · 0 comments
Closed

Absolute url twig extension not working with query strings only #23260

alexander-schranz opened this issue Jun 22, 2017 · 0 comments
Labels
Bug Status: Needs Review TwigBridge

Comments

@alexander-schranz
Copy link
Contributor
alexander-schranz commented Jun 22, 2017 •
edited
Loading
Q A
Bug report? yes
Feature request? no
BC Break report? yes?
RFC? no
Symfony version > 2.8 <= 3.3?

absolute_url twig extension not working with query strings ?test=1 only.

{{ absolute_url('?foo=bar') }}
@alexander-schranz alexander-schranz mentioned this issue Jun 22, 2017
Closed
fabpot added a commit that referenced this issue Jul 6, 2017
@fabpot
bug #23261 Fixed absolute url generation for query strings and hash u…
4e2a404 
…rls (alexander-schranz)

This PR was squashed before being merged into the 2.7 branch (closes #23261).

Discussion
----------

Fixed absolute url generation for query strings and hash urls

| Q             | A
| ------------- | ---
| Branch?       | 2.7, ...
| Bug fix?      | yes
| New feature?  |no
| BC breaks?    | yes? absolute_url will change its output but the old was incorrect
| Deprecations? |no
| Tests pass?   | yes?
| Fixed tickets | fixes #23260
| License       | MIT

Fixed absolute url generation for query strings

Commits
-------

89ad27d Fixed absolute url generation for query strings and hash urls
@fabpot fabpot closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review TwigBridge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @alexander-schranz @carsonbot
0