8000 Don't trim strings in the VarDumper dumps of the profiler · Issue #20669 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

Don't trim strings in the VarDumper dumps of the profiler #20669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Nov 28, 2016 · 8 comments
Closed

Don't trim strings in the VarDumper dumps of the profiler #20669

javiereguiluz opened this issue Nov 28, 2016 · 8 comments
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) VarDumper WebProfilerBundle

Comments

@javiereguiluz
Copy link
Member

Although I love the use of VarDumper in the 3.2 RC2 profiler, we should tweak it a bit to hurt its DX. Specifically, we should never trim strings:

trimmed-strings-1

trimmed-strings-2

After #20380 I though this was fixed. Should we make this change in other places? Is something wrong on my side?
@javiereguiluz javiereguiluz added DX DX = Developer eXperience (anything that improves the experience of using Symfony) VarDumper WebProfilerBundle labels Nov 28, 2016
@chalasr
Copy link
Member
chalasr commented Nov 28, 2016

Indeed. Commenting out this line fixes it, but not sure about how it could be for the profiler only :/

@nicolas-grekas
Copy link
Member

These are CSS ellipses indeed, and personally I find it more convenient to have them than having long lines that spans on several lines and make it hard to read the important info, which is the class name, not its namespace...

@wouterj
Copy link
Member
wouterj commented Nov 28, 2016

Can we maybe readd the previous behaviour of class names in the profiler? (showing only the class name, with the FQCN as title)

@nicolas-grekas
Copy link
Member

Note that the fqcn is still the title, and that it is also copy-pasteable.

@nicolas-grekas
Copy link
Member

What about changing the color of the namespace instead?
E.g. using the "default" color on dumps:

capture du 2016-11-29 10-16-29

@javiereguiluz
Copy link
Member Author

When redesigning the profiler for Symfony 2.8 I also thought about displaying some information in a compact way (e.g. the logger panel). However, I think this is wrong.

The profiler is where you go when something is wrong, so you need all information at once. We don't need to make information compact and it doesn't matter if a log line spans 4 or 5 rows. Of course we can apply "intelligent design" to make important parts stand out, like the class/method names, and to fade others, like the namespace.

@nicolas-grekas nicolas-grekas mentioned this issue Nov 29, 2016
Merged
nicolas-grekas added a commit that referenced this issue Nov 29, 2016
@nicolas-grekas
bug #20679 [VarDumper] Use default color for ellipsed namespaces/path…
726c781 
…s (nicolas-grekas)

This PR was merged into the 3.2 branch.

Discussion
----------

[VarDumper] Use default color for ellipsed namespaces/paths

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20669
| License       | MIT
| Doc PR        | -

Eases readability by helping the eye to focus more quickly on the class name and less on its namespace.
And let' disable ellipses on the profiler panels, fixing #20669 meanwhile.

![capture du 2016-11-29 11-00-00](https://cloud.githubusercontent.com/assets/243674/20705475/5d512c9a-b623-11e6-881d-04ae58453824.png)

Commits
-------

ebc23cf [VarDumper] Use default color for ellipsed namespaces/paths
@ogizanagi
Copy link
Contributor

Does #20679 closes this one or is there anything else to do?

@nicolas-grekas
Copy link
Member

Done

ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@nicolas-grekas
bug symfony#20679 [VarDumper] Use default color for ellipsed namespac…
16d005d 
…es/paths (nicolas-grekas)

This PR was merged into the 3.2 branch.

Discussion
----------

[VarDumper] Use default color for ellipsed namespaces/paths

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#20669
| License       | MIT
| Doc PR        | -

Eases readability by helping the eye to focus more quickly on the class name and less on its namespace.
And let' disable ellipses on the profiler panels, fixing symfony#20669 meanwhile.

![capture du 2016-11-29 11-00-00](https://cloud.githubusercontent.com/assets/243674/20705475/5d512c9a-b623-11e6-881d-04ae58453824.png)

Commits
-------

ebc23cf [VarDumper] Use default color for ellipsed namespaces/paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) VarDumper WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @nicolas-grekas @wouterj @ogizanagi @chalasr
0