8000 Doctrine collector breaks on master with twig 1.26@dev · Issue #20125 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Doctrine collector breaks on master with twig 1.26@dev #20125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ro0NL opened this issue Oct 2, 2016 · 2 comments
Closed

Doctrine collector breaks on master with twig 1.26@dev #20125

ro0NL opened this issue Oct 2, 2016 · 2 comments

Comments

@ro0NL
Copy link
Contributor
ro0NL commented Oct 2, 2016 •
edited
Loading

After updating to twig 1.26@dev on symfony 3.2@dev things tend to crash;

An exception has been thrown during the compilation of a template 
("Method Symfony\Bridge\Twig\Extension\HttpKernelRuntime::controller() does not exist")
in "@Doctrine/Collector/db.html.twig".

see https://github.com/doctrine/DoctrineBundle/blob/1.6.4/Resources/views/Collector/db.html.twig#L113
and #20079 (comment)
@fabpot
Copy link
Member
fabpot commented Oct 2, 2016

1.26 is out now.

@fabpot fabpot closed this as completed Oct 2, 2016
@ro0NL
Copy link
Contributor Author
ro0NL commented Oct 2, 2016

@fabpot the doctrine issue persists.. it happens when loading the toolbar.

image

Exception is shown at /_profiler/<token>

@ro0NL ro0NL mentioned this issue Oct 2, 2016
Merged
fabpot added a commit that referenced this issue Oct 2, 2016
@fabpot
bug #20129 [TwigBridge] Fixed unknown controller method (ro0NL)
669478d 
This PR was merged into the 3.2-dev branch.

Discussion
----------

[TwigBridge] Fixed unknown controller method

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20125 (comment)
| License       | MIT
| Doc PR        | reference to the documentation PR, if any

@fabpot can you have a look :) Im not sure this concerns BC.. but perhaps it makes sense moving this method as well.

Commits
-------

e45e80e fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @ro0NL
0