8000 Too much right margin on toolbar without route · Issue #19805 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Too much right margin on toolbar without route #19805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wouterj opened this issue Aug 31, 2016 · 1 comment
Closed

Too much right margin on toolbar without route #19805

wouterj opened this issue Aug 31, 2016 · 1 comment
Labels
Bug Status: Reviewed WebProfilerBundle

Comments

@wouterj
Copy link
Member
wouterj commented Aug 31, 2016

When there is no route, e.g. a 404 page, the route item is not shown in the toolbar. This results in too much right margin in the status item:

sf-toolbar-wrong-margin
@javiereguiluz
Copy link
Member

I can confirm this issue. Wouter, thanks for reporting it.

@jameshalsall jameshalsall mentioned this issue Sep 1, 2016
Merged
fabpot added a commit that referenced this issue Sep 1, 2016
@fabpot
bug #19812 [WebProfilerBundle] Fix margin on toolbar route panel when…
dfd1d2d 
… no route is found in the request (jameshalsall)

This PR was merged into the 3.1 branch.

Discussion
----------

[WebProfilerBundle] Fix margin on toolbar route panel when no route is found in the request

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19805
| License       | MIT

Just to clarify, this bug was introduced in the 3.1 release when some of the toolbar was re-structured

Commits
-------

7fdffd1 [WebProfilerBundle] Fix margin on toolbar route panel.
@fabpot fabpot closed this as completed Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @javiereguiluz @wouterj
0