8000 [3.0][WebProfilerBundle] Ajax toolbar block not showing up · Issue #16880 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[3.0][WebProfilerBundle] Ajax toolbar block not showing up #16880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mpiecko opened this issue Dec 7, 2015 · 4 comments
Closed

[3.0][WebProfilerBundle] Ajax toolbar block not showing up #16880

mpiecko opened this issue Dec 7, 2015 · 4 comments
Labels
Bug Status: Needs Review WebProfilerBundle

Comments

@mpiecko
Copy link
Contributor
mpiecko commented Dec 7, 2015

I installed a fresh Symfony 3 project on a Debian Jessie release (PHP 5.6) with

symfony new Symfony3

I noticed that the Ajax toolbar block is not showing up. I also noticed, that the twig template with the "sf-toolbar-block-ajax" block is not even injected:

image
image

I'm not sure if this is related, but the DB icon is also missing, although the DB panel is available:

image
image

Michael
@javiereguiluz
Copy link
Member

@jelte that's right: if there are no Ajax calls, you won't see that panel.

@mpiecko about the "ghost Doctrine panel", I need to investigate the issue further.

@mpiecko
Copy link
Contributor Author
mpiecko commented Dec 8, 2015

Thanks @javiereguiluz, but i tested it with Angular, and it worked fine with Symfony 2.7. The problem is: everything works, i see all the requests in the profiler. The only thing that doesn't work is the ajax block inside the debug ba 8000 r.

And, more importantly, i see that the JavaScript block for tracking the ajax requests is there - but there is no "sf-toolbar-block-ajax" markup block (see my screenshot). So the call form the ajax handler with

var ajaxToolbarPanel = document.querySelector('.sf-toolbar-block-ajax');

leads to nowhere. My understanding is that the markup should be there, even if no ajax is performed. But it isn't. So it won't show up if an ajax call is triggered later.

Cheers,
Michael

@NothingWeAre NothingWeAre mentioned this issue Dec 10, 2015
Merged
@NothingWeAre
Copy link
Contributor

it seems that there is no declaration for Ajax collector in
https://github.com/symfony/symfony/blob/3.0/src/Symfony/Bundle/FrameworkBundle/Resources/config/collectors.xml
for 3.0 branch.

Because of that, template that required for displaying ajax calls not included into debug toolbar rendering.

i have created pull request, but this is my first pull request on github so i may have made some mistakes.
#16953

@xabbuh xabbuh added the Bug label Dec 10, 2015
stof added a commit that referenced this issue Dec 10, 2015
@stof
bug #16953 return ajax collector to collectors.php (NothingWeAre)
bb1c6f6 
This PR was merged into the 3.0 branch.

Discussion
----------

return ajax collector to collectors.php

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #16880
| License       | MIT
| Doc PR        |

in symfony 3.0 there is no ajax collector declared. Because of that debug toolbar do not display ajax calls

Commits
-------

8a2c757 return ajax collector to collectors.php
@stof stof closed this as completed Dec 10, 2015
@mpiecko
Copy link
Contributor Author
mpiecko commented Dec 10, 2015

Can confirm, this fixed it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@javiereguiluz @mpiecko @stof @xabbuh @carsonbot @NothingWeAre
0