8000 Deprecation callstack line number in profiler off by one · Issue #16640 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Deprecation callstack line number in profiler off by one #16640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weaverryan opened this issue Nov 23, 2015 · 3 comments
Closed

Deprecation callstack line number in profiler off by one #16640

weaverryan opened this issue Nov 23, 2015 · 3 comments

Comments

@weaverryan
Copy link
Member

I'm using symfony-demo as an upgrade example for a tutorial, and I noticed that the deprecation are off by one entry. Well, maybe not off but it doesn't read quite right:

screen shot 2015-11-23 at 12 00 19 pm

In fact, line 89 should refer to ResourceCheckerConfigCache::isFresh() - there is no line 89 in BCResourceInterfaceChecker. And ResourceCheckerConfigCache doesn't do anything on line 45 - it's actually ResourceCheckerConfigCacheFactory that does work on line 45.

Thoughts @javiereguiluz?
@stof
Copy link
Member
stof commented Nov 23, 2015

@nicolas-grekas can you check this as well ? The issue is either in the display or in the data being sent (or in a misunderstanding between them)

@nicolas-grekas
Copy link
Member

the issue is in the template, thus for @javiereguiluz : php stack traces give what has been called in this file on that line. Called from foobar at line 89 should be something like Calling foobar at line 89. This is a bizarre thing of PHP. If you want to display it this way (which is perfectly fine), then the logic should associate file+line to the previous class+type+function in the stack.

@javiereguiluz javiereguiluz mentioned this issue Nov 25, 2015
Merged
Tobion added a commit that referenced this issue Nov 25, 2015
@Tobion
minor #16658 Fixes the stack traces of the deprecation logs (javiereg…
1abfecf 
…uiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Fixes the stack traces of the deprecation logs

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16640
| License       | MIT
| Doc PR        |

The stack trace information was displayed in a very confusing way. Now it's easier to understand what is called from which file and line.

### Before

![stack_trace_before](https://cloud.githubusercontent.com/assets/73419/11392640/5c02607a-935b-11e5-8f99-812fbd97aad3.png)

### After

![stack_trace_after](https://cloud.githubusercontent.com/assets/73419/11392650/5f0b821a-935b-11e5-8472-7fae9bd21149.png)

Commits
-------

09f4895 Fixes the stack traces of the deprecation logs
@javiereguiluz
Copy link
Member

We can close this issue because it was fixed in #16658. Thanks.

@fabpot fabpot closed this as completed Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @javiereguiluz @weaverryan @nicolas-grekas @stof @xabbuh
0