8000 [Console] The new backrounds are unreadable in putty · Issue #16257 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] The new backrounds are unreadable in putty #16257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mvrhov opened this issue Oct 16, 2015 · 6 comments
Closed

[Console] The new backrounds are unreadable in putty #16257

mvrhov opened this issue Oct 16, 2015 · 6 comments
Labels
Console

Comments

@mvrhov
Copy link
mvrhov commented Oct 16, 2015

I run console commands mostly via putty.
I haven't seen all the backgrounds yet, but at least the green one is unreadable.

untitled
@javiereguiluz
Copy link
Member

I have a question about this: when running PHPUnit tests, do you have the same issues with the result bar or is it more readable?

phpunit_green_background

@mvrhov
Copy link
Author
mvrhov commented Oct 19, 2015

The tests don't pass in my environment so I cannot answer that.

Tests: 14639, Assertions: 27363, Errors: 11, Failures: 11, Skipped: 843, Incomplete: 12.

@stof
Copy link
Member
stof commented Oct 19, 2015

@mvrhov use a subset of the testsuite which passes, by passing a path to some tests

@mvrhov
Copy link
Author
mvrhov commented Oct 19, 2015

For that I get black text on green background:

untitled
P.S. The light grey on red for errors was readable before and is still readable.

@javiereguiluz
Copy link
Member

PHPUnit uses:

  • 'fg-black, bg-green' for success (see code)
  • 'fg-black, bg-yellow' for warnings (see code)
  • 'fg-white, bg-red' for errors (see code)

Maybe we should do the same in these functions defined in the SymfonyStyle class.

@xabbuh
Copy link
Member
xabbuh commented Oct 20, 2015

seems reasonable

@xabbuh xabbuh added the Console label Oct 20, 2015
@javiereguiluz javiereguiluz mentioned this issue Oct 20, 2015
Merged
Tobion added a commit that referenced this issue Oct 22, 2015
@Tobion
bug #16298 Changed one console output style to avoid visual issues (j…
8403028 
…aviereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Changed one console output style to avoid visual issues

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16257
| License       | MIT
| Doc PR        | -

Read [this comment](#16257 (comment)) for the rationale behind this change.

Commits
-------

3c4e458 Changed one console output style to avoid visual issues
@Tobion Tobion closed this as completed Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @stof @mvrhov @Tobion @xabbuh
0