8000 SymfonyStyleTest is failing when being run from a small-width terminal · Issue #15909 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

SymfonyStyleTest is failing when being run from a small-width terminal #15909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Sep 26, 2015 · 1 comment
Closed

SymfonyStyleTest is failing when being run from a small-width terminal #15909

stof opened this issue Sep 26, 2015 · 1 comment

Comments

@stof
Copy link
Member
stof commented Sep 26, 2015

The test should force the terminal width in the application to ensure a consistent output for expectations.
This concerns Symfony 2.7+
@1ed
Copy link
Contributor
1ed commented Sep 26, 2015

This can not be fixed right now because SymfonyStyle.php#L371.

What do you think about rename that method to getDefaultTerminalWidth() and add public getTerminalWidth() and setTerminalWidth($width) methods and getTerminalWidth() should fall back to getDefaultTerminalWidth()? I can work on it if sounds good.

Edit: Nevermind, that does not solve the issue.

@1ed 1ed mentioned this issue Sep 28, 2015
Merged
fabpot added a commit that referenced this issue Oct 1, 2015
@fabpot
minor #15967 [Console] Fix tests for SymfonyStyle (1ed)
a94d7a0 
This PR was merged into the 2.7 branch.

Discussio
568A
n
----------

[Console] Fix tests for SymfonyStyle

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15909
| License       | MIT
| Doc PR        | -

Commits
-------

7720f5c [Console] Fix tests for SymfonyStyle
@fabpot fabpot closed this as completed Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @1ed @stof
0