8000 [FrameworkBundle] Undefined index: templating · Issue #13710 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Undefined index: templating #13710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddeboer opened this issue Feb 17, 2015 · 1 comment
Closed

[FrameworkBundle] Undefined index: templating #13710

ddeboer opened this issue Feb 17, 2015 · 1 comment

Comments

@ddeboer
Copy link
Contributor
ddeboer commented Feb 17, 2015

https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L59 assumes the templating key to be available, but shouldn’t there be an isset check, as templating can be optional?
@jakzal jakzal mentioned this issue Feb 17, 2015
Merged
@jakzal
Copy link
Contributor
jakzal commented Feb 17, 2015

Good spot! I went back and forward with the condition in ifTrue() and this condition got eventually removed.

fabpot added a commit that referenced this issue Feb 17, 2015
@fabpot
bug #13711 [FrameworkBundle] Check if templating is enabled. (jakzal)
a630d87 
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Check if templating is enabled.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13710
| License       | MIT
| Doc PR        | -

templating can be disabled.

Commits
-------

c75b276 [FrameworkBundle] Check if templating is enabled.
@fabpot fabpot closed this as completed Feb 17, 2015
ddeboer added a commit to FriendsOfSymfony/FOSHttpCacheBundle that referenced this issue Feb 20, 2015
@ddeboer
Revert our workaround because Symfony is fixed
6668312 
symfony/symfony#13710 has been fixed.
@ddeboer ddeboer mentioned this issue Feb 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @ddeboer @jakzal
0