8000 [WebProfilerBundle] add "http status" column in the "Search Results" list · Issue #12944 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
8000

[WebProfilerBundle] add "http status" column in the "Search Results" list #12944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elementaire opened this issue Dec 11, 2014 · 3 comments
Closed

Comments

@elementaire
Copy link
Contributor

Consider adding the "http status" directly in the table list of the "Search Results" in the SymfonyProfiler to identify quickly the issue (500, 401, etc.), maybe after the "Method" column.

I am working with another developper ; he is using the API i developped. His app launchs several calls by page ; it is hard to find which request fails in this list.

@xelaris
Copy link
Contributor
xelaris commented Dec 18, 2014

I like the idea, since I also came in situations where I need to pick a specific failed request from the list. I'll provide a pull request for that.

@aitboudad
Copy link
Contributor

👍

@elementaire elementaire changed the title [SymfonyProfiler] add "http status" column in the "Search Results" list [WebProfilerBundle] add "http status" column in the "Search Results" list Dec 22, 2014
@elementaire
Copy link
Contributor Author

👍

fabpot added a commit that referenced this issue Jan 25, 2015
…profiler search result (xelaris)

This PR was squashed before being merged into the 2.7 branch (closes #13034).

Discussion
----------

[HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12944
| License       | MIT
| Doc PR        |

With this PR HTTP status codes are provided in the search results to simplify identification of particular requests.
For the schema-less storage implementations (memcache(d), redis, mongodb) and the default file storage, it should work without purging existing profiles. But the code could be simplified, if it is an option to expect old profiles to be purged. For database driven storages (mysql, sqlite), the `sf_profiler_data` table must be dropped anyway (if the table isn't altered manually by adding the `status_code` column). Thus the changes are not fully BC.

![profiler-search-results](https://cloud.githubusercontent.com/assets/2466932/5499453/3cc6ad70-8730-11e4-81e5-13bfd1140d00.png)

Commits
-------

34ecda5 [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result
@fabpot fabpot closed this as completed Jan 25, 2015
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
…tus to profiler search result (xelaris)

This PR was squashed before being merged into the 2.7 branch (closes symfony#13034).

Discussion
----------

[HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#12944
| License       | MIT
| Doc PR        |

With this PR HTTP status codes are provided in the search results to simplify identification of particular requests.
For the schema-less storage implementations (memcache(d), redis, mongodb) and the default file storage, it should work without purging existing profiles. But the code could be simplified, if it is an option to expect old profiles to be purged. For database driven storages (mysql, sqlite), the `sf_profiler_data` table must be dropped anyway (if the table isn't altered manually by adding the `status_code` column). Thus the changes are not fully BC.

![profiler-search-results](https://cloud.githubusercontent.com/assets/2466932/5499453/3cc6ad70-8730-11e4-81e5-13bfd1140d00.png)

Commits
-------

34ecda5 [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
0