10000 [Form] Remove "*_timezone" options from date/time type · Issue #12239 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Remove "*_timezone" options from date/time type #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
webmozart opened this issue Oct 16, 2014 · 2 comments
Closed

[Form] Remove "*_timezone" options from date/time type #12239

webmozart opened this issue Oct 16, 2014 · 2 comments
Labels
Enhancement Form

Comments

@webmozart
Copy link
Contributor

As discussed in #7187, these options don't make sense for these types.
This was referenced Oct 16, 2014
Closed
Closed
This was referenced Nov 2, 2014
Closed
Closed
fabpot added a commit that referenced this issue Nov 16, 2014
@fabpot
feature #12404 [Form] Remove timezone options from DateType and TimeT…
75d8d8f 
…ype (jakzal)

This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12404).

Discussion
----------

[Form] Remove timezone options from DateType and TimeType

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12239
| License       | MIT
| Doc PR        | symfony/symfony-docs#4417

replaces #12380

Commits
-------

849fb29 Drop support for model_timezone and view_timezone options in TimeType and DateType.
@fabpot fabpot closed this as completed Nov 16, 2014
@stof
Copy link
Member
stof commented Nov 21, 2014

We should document them as deprecated in 2.6 IMO (as they are not working properly anyway) and add a deprecation warning for them in 2.7 when they are used

@stof
Copy link
Member
stof commented Nov 21, 2014

OK no, I missed that the target branch for the merge was changed to 2.6

@tkleinhakisa tkleinhakisa mentioned this issue Jan 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @webmozart @stof
0