8000 Add support for new Forwarded header in Request::getClientIps · Issue #11073 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add support for new Forwarded header in Request::getClientIps #11073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Seldaek opened this issue Jun 7, 2014 · 1 comment
Closed

Add support for new Forwarded header in Request::getClientIps #11073

Seldaek opened this issue Jun 7, 2014 · 1 comment
Labels
Enhancement HttpFoundation

Comments

@Seldaek
Copy link
Member
Seldaek commented Jun 7, 2014

RFC7239 defines a Forwarded header that regroups all the X-Forwarded-{For,By,Proto,Port} into one header. Support should be added in https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L782
@tony-co
Copy link
tony-co commented Jul 11, 2014

Nice addition, I'll look into it

@tony-co tony-co mentioned this issue Jul 11, 2014
Closed
fabpot added a commit that referenced this issue Feb 8, 2015
@fabpot
feature #11379 Added new Forwarded header support for Request::getCli…
ac389b6 
…entIps (tony-co)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #11379).

Discussion
----------

Added new Forwarded header support for Request::getClientIps

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11073
| License       | MIT
| Doc PR        | no

Commits
-------

4c8a25a Added new Forwarded header support for Request::getClientIps
@fabpot fabpot closed this as completed Feb 8, 2015
@fbender fbender mentioned this issue Sep 19, 2015
Closed
@arjenm arjenm mentioned this issue Apr 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @Seldaek @tony-co
0