8000 FrameworkBundle tests are broken · Issue #10622 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

FrameworkBundle tests are broken #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakzal opened this issue Apr 2, 2014 · 0 comments
Closed

FrameworkBundle tests are broken #10622

jakzal opened this issue Apr 2, 2014 · 0 comments
Labels
FrameworkBundle

Comments

@jakzal
Copy link
Contributor
jakzal commented Apr 2, 2014

Tests are failing on php >= 5.5 since there's no APC support.

Broken in #10287.
Latest working commit: 3dc2b4d
Broken by: 0bfde4a

https://travis-ci.org/symfony/symfony/jobs/22120558#L225

ping @webmozart
@jakzal jakzal mentioned this issue Apr 3, 2014
Merged
fabpot added a commit that referenced this issue Apr 3, 2014
@fabpot
minor #10632 [FrameworkBundle] Fix tests (jakzal)
27035b4 
This PR was merged into the 2.5-dev branch.

Discussion
----------

[FrameworkBundle] Fix tests

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10622
| License       | MIT
| Doc PR        | -

This [fixes the build](https://travis-ci.org/jakzal/symfony/builds/22199535) [![Build Status](https://travis-ci.org/jakzal/symfony.svg?branch=framework-bundle-tests-fix)](https://travis-ci.org/jakzal/symfony) by only initializing a fully configured validation service if APC is available. At the moment we only provide ApcCache for mapping' caching (out of the box). DoctrineCache is available but not configured. I also added an additional test case to verify that a validation service can be created on php >=5.5.

Commits
-------

009c4b8 [FrameworkBundle] Only initialize a fully configured service if APC is available.
@fabpot fabpot closed this as completed Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @jakzal
0