[TwigBundle] fix findTemplate() to return null

dpesch · dpesch · commit fc0c369996b1 · 2019-12-08T12:35:30.000+01:00
Twig 3 expects `null` instead of `false` (see <https://github.com/twigphp/Twig/blob/3.x/src/Loader/FilesystemLoader .php#L167> and <https://github.com/twigphp/Twig/blob/a5f91f3d8fb2965be8b715323dbdc81ce288a14a/src/Loader/FilesystemLoader.php#L153> Returning `null` fixes `exists()` of Twig 3 FilesystemLoader without breaking Twig 2 (which expected `null` or `false` for not found templates).
diff --git a/src/Symfony/Bundle/TwigBundle/Loader/FilesystemLoader.php b/src/Symfony/Bundle/TwigBundle/Loader/FilesystemLoader.php
@@ -96,7 +96,7 @@ protected function findTemplate($template, $throw = true)
                 throw $twigLoaderException;
             }
 
-            return false;
+            return null;
         }
 
         return $this->cache[$logicalName] = $file;

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ protected function findTemplate($template, $throw = true)`
`96`	`96`	`throw $twigLoaderException;`
`97`	`97`	`}`
`98`	`98`
`99`		`- return false;`
	`99`	`+ return null;`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`return $this->cache[$logicalName] = $file;`